[webcrypto] Set the error type for failures.

content/child/webcrypto/jwk.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <functional>
 #include <map>
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
@@ skipping 776 matching lines @@
 
   }
 
   return Status::ErrorJwkUnrecognizedKty();
 }
 
 Status ExportKeyJwk(const blink::WebCryptoKey& key,
                     blink::WebArrayBuffer* buffer) {
   DCHECK(key.extractable());
   base::DictionaryValue jwk_dict;
-  Status status = Status::Error();
+  Status status = Status::OperationError();

[Ryan Sleevi, 2014/04/22 23:45:50]

What part of the spec led you to believe this was the right error? I can't find
any support for it. Then again, this value is never returned - so seems worth
documenting that it's a dummy value? Or just use Status::Error?

[eroman, 2014/04/23 00:11:30]

I renamed Status::Error() to Status::OperationError(), since there isn't an
equivalent generic error for the exceptions.

 
   switch (key.type()) {
     case blink::WebCryptoKeyTypeSecret: {
       blink::WebArrayBuffer exported_key;
       status = ExportKey(blink::WebCryptoKeyFormatRaw, key, &exported_key);
       if (status.IsError())
         return status;
       WriteSecretKey(exported_key, &jwk_dict);
       break;
     }
@@ skipping 28 matching lines @@
   std::string json;
   base::JSONWriter::Write(&jwk_dict, &json);
   *buffer = CreateArrayBuffer(reinterpret_cast<const uint8*>(json.data()),
                               json.size());
   return Status::Success();
 }
 
 }  // namespace webcrypto
 
 }  // namespace content