Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

Issue 2434263002: 📰 Refresh the visiblity of AllDismissed when items change (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
index eafab2d4f6ccf664ba95561fc2b512d3de3ec3c7..6ad09d780b1fb9cbe7df840821935dcda256c609 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
@@ -11,6 +11,7 @@
import android.support.v7.widget.RecyclerView;
import org.chromium.base.ContextUtils;
+import org.chromium.base.VisibleForTesting;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ntp.NewTabPage.DestructionObserver;
@@ -125,7 +126,7 @@ public boolean isShown() {
}
/** Attempts to show the sign in promo. If the user dismissed it before, it will not be shown.*/
- public void maybeShow() {
+ private void maybeShow() {
if (mVisible) return;
mVisible = true;
@@ -136,7 +137,7 @@ public void maybeShow() {
}
/** Hides the sign in promo. */
- public void hide() {
+ private void hide() {
if (!mVisible) return;
mVisible = false;
@@ -154,7 +155,8 @@ public void dismiss() {
mObserver.unregister();
}
- private class SigninObserver
+ @VisibleForTesting
+ class SigninObserver
implements SignInStateObserver, SignInAllowedObserver, DestructionObserver {
private final SigninManager mSigninManager;
private final NewTabPageAdapter mAdapter;

Powered by Google App Engine
This is Rietveld 408576698