Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2434123002: test.dart: Push all required files to Android device when running AOT tests (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

test.dart: Push all required files to Android device when running AOT tests Some tests have resources in sub-directories (e.g. certificates/) Remove status file lines for tests that are now passing. Fixes #26376,#26377. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b85f900cb7036d49f02efc1ba1095a01a6fc4263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M tests/standalone/standalone.status View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 2 months ago (2016-10-19 23:47:14 UTC) #3
rmacnak
lgtm
4 years, 2 months ago (2016-10-19 23:49:02 UTC) #4
Florian Schneider
4 years, 2 months ago (2016-10-19 23:50:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b85f900cb7036d49f02efc1ba1095a01a6fc4263 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698