Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: webrtc/modules/video_coding/include/video_coding.h

Issue 2434073003: Extract bitrate allocation of spatial/temporal layers out of codec impl. (Closed)
Patch Set: Updated tl listener registration. Fixed tests. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 17 matching lines...) Expand all
28 #include "webrtc/video_frame.h" 28 #include "webrtc/video_frame.h"
29 29
30 namespace webrtc { 30 namespace webrtc {
31 31
32 class Clock; 32 class Clock;
33 class EncodedImageCallback; 33 class EncodedImageCallback;
34 // TODO(pbos): Remove VCMQMSettingsCallback completely. This might be done by 34 // TODO(pbos): Remove VCMQMSettingsCallback completely. This might be done by
35 // removing the VCM and use VideoSender/VideoReceiver as a public interface 35 // removing the VCM and use VideoSender/VideoReceiver as a public interface
36 // directly. 36 // directly.
37 class VCMQMSettingsCallback; 37 class VCMQMSettingsCallback;
38 class VideoBitrateAllocator;
38 class VideoEncoder; 39 class VideoEncoder;
39 class VideoDecoder; 40 class VideoDecoder;
40 struct CodecSpecificInfo; 41 struct CodecSpecificInfo;
41 42
42 class EventFactory { 43 class EventFactory {
43 public: 44 public:
44 virtual ~EventFactory() {} 45 virtual ~EventFactory() {}
45 46
46 virtual EventWrapper* CreateEvent() = 0; 47 virtual EventWrapper* CreateEvent() = 0;
47 }; 48 };
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 // - target_bitrate : The target bitrate for VCM in bits/s. 160 // - target_bitrate : The target bitrate for VCM in bits/s.
160 // - lossRate : Fractions of lost packets the past second. 161 // - lossRate : Fractions of lost packets the past second.
161 // (loss rate in percent = 100 * packetLoss / 162 // (loss rate in percent = 100 * packetLoss /
162 // 255) 163 // 255)
163 // - rtt : Current round-trip time in ms. 164 // - rtt : Current round-trip time in ms.
164 // 165 //
165 // Return value : VCM_OK, on success. 166 // Return value : VCM_OK, on success.
166 // < 0, on error. 167 // < 0, on error.
167 virtual int32_t SetChannelParameters(uint32_t target_bitrate, 168 virtual int32_t SetChannelParameters(uint32_t target_bitrate,
168 uint8_t lossRate, 169 uint8_t lossRate,
169 int64_t rtt) = 0; 170 int64_t rtt,
perkj_webrtc 2016/10/21 08:24:29 We no longer use the module. Instead we use the se
sprang_webrtc 2016/10/25 10:44:25 Acknowledged.
171 VideoBitrateAllocator* allocator) = 0;
170 172
171 // Sets the parameters describing the receive channel. These parameters are 173 // Sets the parameters describing the receive channel. These parameters are
172 // inputs to the 174 // inputs to the
173 // Media Optimization inside the VCM. 175 // Media Optimization inside the VCM.
174 // 176 //
175 // Input: 177 // Input:
176 // - rtt : Current round-trip time in ms. 178 // - rtt : Current round-trip time in ms.
177 // with the most amount available bandwidth in 179 // with the most amount available bandwidth in
178 // a conference 180 // a conference
179 // scenario 181 // scenario
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 470
469 virtual void RegisterPostEncodeImageCallback( 471 virtual void RegisterPostEncodeImageCallback(
470 EncodedImageCallback* post_encode_callback) = 0; 472 EncodedImageCallback* post_encode_callback) = 0;
471 // Releases pending decode calls, permitting faster thread shutdown. 473 // Releases pending decode calls, permitting faster thread shutdown.
472 virtual void TriggerDecoderShutdown() = 0; 474 virtual void TriggerDecoderShutdown() = 0;
473 }; 475 };
474 476
475 } // namespace webrtc 477 } // namespace webrtc
476 478
477 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_H_ 479 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698