Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2434073002: [sensors] PlatformSensorProvider implementations are notified when there are no sensor instances (Closed)

Created:
4 years, 2 months ago by Mikhail
Modified:
4 years, 1 month ago
Reviewers:
shalamov, timvolodine
CC:
chromium-reviews, maksims (do not use this acc), darktears
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors] PlatformSensorProvider implementations are notified when there are no sensor instances The protected virtual 'AllSensorsRemoved' method is added to PlatformSensorProviderBase class. Unit tests are also included. BUG=606766 Committed: https://crrev.com/90f1d34ecc7699705c95df05e1b04f921007dba6 Cr-Commit-Position: refs/heads/master@{#427049}

Patch Set 1 : [sensors] PlatformSensorProvider implementations are notified when there are no sensor instances #

Total comments: 1

Patch Set 2 : Added 'HasSensors' #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -23 lines) Patch
M device/generic_sensor/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M device/generic_sensor/fake_platform_sensor_provider.h View 2 chunks +2 lines, -1 line 0 comments Download
M device/generic_sensor/fake_platform_sensor_provider.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M device/generic_sensor/platform_sensor_provider_base.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M device/generic_sensor/platform_sensor_provider_base.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M device/generic_sensor/platform_sensor_provider_unittest.cc View 1 4 chunks +29 lines, -14 lines 0 comments Download

Messages

Total messages: 35 (26 generated)
Mikhail
PTAL
4 years, 2 months ago (2016-10-19 19:46:54 UTC) #5
shalamov
https://codereview.chromium.org/2434073002/diff/20001/device/generic_sensor/platform_sensor_provider_base.h File device/generic_sensor/platform_sensor_provider_base.h (right): https://codereview.chromium.org/2434073002/diff/20001/device/generic_sensor/platform_sensor_provider_base.h#newcode43 device/generic_sensor/platform_sensor_provider_base.h:43: virtual void AllSensorsRemoved() {} Can you also add bool ...
4 years, 2 months ago (2016-10-20 06:37:26 UTC) #13
Mikhail
On 2016/10/20 06:37:26, shalamov wrote: > https://codereview.chromium.org/2434073002/diff/20001/device/generic_sensor/platform_sensor_provider_base.h > File device/generic_sensor/platform_sensor_provider_base.h (right): > > https://codereview.chromium.org/2434073002/diff/20001/device/generic_sensor/platform_sensor_provider_base.h#newcode43 > ...
4 years, 2 months ago (2016-10-20 08:04:19 UTC) #16
shalamov
lgtm
4 years, 2 months ago (2016-10-20 08:08:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434073002/40001
4 years, 1 month ago (2016-10-24 06:26:53 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/320730)
4 years, 1 month ago (2016-10-24 06:28:43 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434073002/60001
4 years, 1 month ago (2016-10-24 09:58:57 UTC) #30
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 1 month ago (2016-10-24 12:02:50 UTC) #32
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 12:04:13 UTC) #35
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/90f1d34ecc7699705c95df05e1b04f921007dba6
Cr-Commit-Position: refs/heads/master@{#427049}

Powered by Google App Engine
This is Rietveld 408576698