chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 2434063002: Move extensions code from WebContents::GetURL to GetLastCommittedURL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 2434063002: Move extensions code from WebContents::GetURL to GetLastCommittedURL.

Patch Set: Refactor to simplify. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index b0bc10e7696ae612ea84446bac640a245717b301..e7ccecf9cd83214fa434d2b7aacc8210cf719de5 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -1339,7 +1339,7 @@ void TabsUpdateFunction::PopulateResult() {

return;

results_ = tabs::Get::Results::Create(

- *ExtensionTabUtil::CreateTabObject(web_contents_, extension()));

+ *ExtensionTabUtil::CreateTabObjectVisibleUrl(web_contents_, extension()));

}

void TabsUpdateFunction::OnExecuteCodeFinished(