Implement contextmenu attribute with basic support of <menu>

Source/core/html/HTMLMenuElement.cpp

Index: Source/core/html/HTMLMenuElement.cpp
diff --git a/Source/core/html/HTMLMenuElement.cpp b/Source/core/html/HTMLMenuElement.cpp
index 5643bc146a52c3d1f01baa1c5615d62d5b3ab43b..3a5de1c8699369450659d76b7cda7606828168cb 100644
--- a/Source/core/html/HTMLMenuElement.cpp
+++ b/Source/core/html/HTMLMenuElement.cpp
@@ -23,7 +23,11 @@
 #include "config.h"
 #include "core/html/HTMLMenuElement.h"
 
-#include "core/HTMLNames.h"
+#include "core/dom/ElementTraversal.h"
+#include "core/events/RelatedEvent.h"
+#include "core/html/HTMLMenuItemElement.h"
+#include "core/page/ContextMenuController.h"
+#include "core/page/Page.h"
 
 namespace WebCore {
 
@@ -37,4 +41,50 @@ inline HTMLMenuElement::HTMLMenuElement(Document& document)
 
 DEFINE_NODE_FACTORY(HTMLMenuElement)
 
+CustomContextMenuProvider& HTMLMenuElement::ensureMenuProvider()
+{
+    if (!m_menuProvider) {
+        ContextMenu menu;
+        populateContextMenuItems(this, menu);

[Inactive, 2014/07/16 20:07:26]

*this

[pals, 2014/07/17 15:35:47]

Done.

+        m_menuProvider = CustomContextMenuProvider::create(this, menu.items());
+    }
+    return *m_menuProvider;
+}
+
+void HTMLMenuElement::populateContextMenuItems(HTMLMenuElement* menu, ContextMenu& contextMenu)

[Inactive, 2014/07/16 20:07:26]

HTMLMenuElement&

[pals, 2014/07/17 15:35:47]

Done.

+{
+    Element* nextElement = ElementTraversal::firstWithin(*menu);

[Inactive, 2014/07/16 20:07:26]

HTMLElement* currentElement = Traversal<HTMLElement>::firstWithin(menu);

since you are only interested in HTMLElements (avoids casting below).

[pals, 2014/07/17 15:35:47]

Done.

+    while (nextElement) {
+        if (nextElement->hasTagName(HTMLNames::menuTag)) {

[Inactive, 2014/07/16 20:07:26]

isHTMLMenuElement(*nextElement)

[pals, 2014/07/17 15:35:47]

Done.

+            ContextMenu subMenu;
+            populateContextMenuItems(toHTMLMenuElement(nextElement), subMenu);
+            contextMenu.appendItem(ContextMenuItem(SubmenuType, ContextMenuItemCustomTagNoAction, nextElement->fastGetAttribute(HTMLNames::labelAttr), &subMenu));
+            nextElement = ElementTraversal::nextSibling(*nextElement);

[Inactive, 2014/07/16 20:07:26]

Traversal<HTMLElement>

[pals, 2014/07/17 15:35:47]

Done.

+        } else if (nextElement->hasTagName(HTMLNames::menuitemTag)) {

[Inactive, 2014/07/16 20:07:26]

isHTMLMenuItemElement(*nextElement)

[pals, 2014/07/17 15:35:47]

Done.

+            m_menuItems.append(toHTMLElement(nextElement));
+            contextMenu.appendItem(ContextMenuItem(ActionType, static_cast<ContextMenuAction>(ContextMenuItemBaseCustomTag + m_menuItems.size() - 1), nextElement->fastGetAttribute(HTMLNames::labelAttr)));
+            if (ContextMenuItemBaseCustomTag + m_menuItems.size() >= ContextMenuItemLastCustomTag)
+                break;
+            nextElement = ElementTraversal::next(*nextElement, menu);

[Inactive, 2014/07/16 20:07:26]

Traversal<HTMLElement>

[pals, 2014/07/17 15:35:47]

Done.

+        }
+    }
+}
+
+void HTMLMenuElement::defaultEventHandler(Event* event)
+{
+    if (event->type() == EventTypeNames::show && event->isRelatedEvent()) {
+        m_subject = toHTMLElement(toRelatedEvent(event)->relatedTarget()->toNode());

[Inactive, 2014/07/16 20:07:26]

Won't this crash if relatedTarget is an EventTarget other than an HTMLElement?

[pals, 2014/07/17 15:35:47]

It should not be anything otherthan HTMLElement as we set it to HTMLElement only
in ContextMenuController.cpp.

+        ensureMenuProvider();
+        event->setDefaultHandled();
+    }
+}
+
+HTMLElement* HTMLMenuElement::menuItemAt(unsigned menuId)
+{
+    if (menuId < ContextMenuItemBaseCustomTag || menuId > ContextMenuItemLastCustomTag)
+        return 0;
+    int itemNumber = menuId - ContextMenuItemBaseCustomTag;
+    return m_menuItems[itemNumber];
+}
+
 }