Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: Source/core/html/HTMLMenuElement.cpp

Issue 243403006: Implement contextmenu attribute with basic support of <menu> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLMenuElement.cpp
diff --git a/Source/core/html/HTMLMenuElement.cpp b/Source/core/html/HTMLMenuElement.cpp
index e043ed557b9176a4132984b499a9040c536cdf3f..18c77f1c60ac56fe66c96f026c8ea1912b703997 100644
--- a/Source/core/html/HTMLMenuElement.cpp
+++ b/Source/core/html/HTMLMenuElement.cpp
@@ -21,9 +21,14 @@
*/
#include "config.h"
+
#include "core/html/HTMLMenuElement.h"
-#include "HTMLNames.h"
+#include "core/dom/ElementTraversal.h"
+#include "core/events/RelatedEvent.h"
+#include "core/html/HTMLMenuitemElement.h"
+#include "core/page/ContextMenuController.h"
+#include "core/page/Page.h"
namespace WebCore {
@@ -40,4 +45,49 @@ PassRefPtrWillBeRawPtr<HTMLMenuElement> HTMLMenuElement::create(Document& docume
return adoptRefWillBeRefCountedGarbageCollected(new HTMLMenuElement(document));
}
+CustomContextMenuProvider& HTMLMenuElement::ensureMenuProvider()
+{
+ if (!m_menuProvider) {
+ ContextMenu menu;
+ populateContextMenuItems(this, menu);
+ m_menuProvider = CustomContextMenuProvider::create(this, menu.items());
+ }
+ return *m_menuProvider;
+}
+
+void HTMLMenuElement::populateContextMenuItems(HTMLMenuElement* menu, ContextMenu& contextMenu)
+{
+ Element* nextElement = ElementTraversal::firstWithin(*menu);
+ while (nextElement) {
+ if (nextElement->hasTagName(HTMLNames::menuTag)) {
+ ContextMenu subMenu;
+ populateContextMenuItems(toHTMLMenuElement(nextElement), subMenu);
+ contextMenu.appendItem(ContextMenuItem(SubmenuType, ContextMenuItemCustomTagNoAction, nextElement->fastGetAttribute(HTMLNames::labelAttr), &subMenu));
+ nextElement = ElementTraversal::nextSibling(*nextElement);
+ } else if (nextElement->hasTagName(HTMLNames::menuitemTag)) {
esprehn 2014/06/20 08:39:57 This doesn't seem to implement the <hr>'s as separ
pals 2014/06/20 14:22:10 Yes, I have skipped the whole separators thing whi
+ m_menuItems.append(toHTMLElement(nextElement));
+ contextMenu.appendItem(ContextMenuItem(ActionType, static_cast<ContextMenuAction>(ContextMenuItemBaseCustomTag + m_menuItems.size() - 1), nextElement->fastGetAttribute(HTMLNames::labelAttr)));
+ if (ContextMenuItemBaseCustomTag + m_menuItems.size() >= ContextMenuItemLastCustomTag)
+ break;
+ nextElement = ElementTraversal::next(*nextElement, menu);
+ }
+ }
+}
+
+void HTMLMenuElement::defaultEventHandler(Event* event)
+{
+ if (event->type() == EventTypeNames::show && event->isRelatedEvent()) {
+ ensureMenuProvider();
+ event->setDefaultHandled();
+ }
+}
+
+HTMLElement* HTMLMenuElement::menuItemAt(unsigned menuId)
+{
+ if (menuId < ContextMenuItemBaseCustomTag || menuId > ContextMenuItemLastCustomTag)
+ return 0;
+ int itemNumber = menuId - ContextMenuItemBaseCustomTag;
+ return m_menuItems[itemNumber];
+}
+
}

Powered by Google App Engine
This is Rietveld 408576698