Implement contextmenu attribute with basic support of <menu>

Source/core/page/ContextMenuController.cpp

 /*
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Igalia S.L
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 10 matching lines @@
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/page/ContextMenuController.h"
 
 #include "core/dom/Document.h"
+#include "core/dom/Node.h"
 #include "core/events/Event.h"
+#include "core/events/EventDispatchMediator.h"
+#include "core/events/EventDispatcher.h"
 #include "core/events/MouseEvent.h"
-#include "core/dom/Node.h"
+#include "core/events/RelatedEvent.h"
 #include "core/frame/LocalFrame.h"
+#include "core/html/HTMLMenuElement.h"
 #include "core/page/ContextMenuClient.h"
 #include "core/page/ContextMenuProvider.h"
 #include "core/page/EventHandler.h"
 #include "platform/ContextMenu.h"
 #include "platform/ContextMenuItem.h"
 
 namespace WebCore {
 
+using namespace HTMLNames;
+
 ContextMenuController::ContextMenuController(Page*, ContextMenuClient* client)
     : m_client(client)
 {
     ASSERT_ARG(client, client);
 }
 
 ContextMenuController::~ContextMenuController()
 {
 }
 
@@ skipping 20 matching lines @@
             clearContextMenu();
     }
 }
 
 void ContextMenuController::handleContextMenuEvent(Event* event)
 {
     m_contextMenu = createContextMenu(event);
     if (!m_contextMenu)
         return;
 
+    Node* node = event->target()->toNode();
+    if (node && node->isElementNode()) {

[esprehn, 2014/05/20 05:51:34]

I think you want isHTMLElement

[pals, 2014/05/21 07:55:12]

Done.

+        const HTMLElement& element = toHTMLElement(*event->target()->toNode());

[esprehn, 2014/05/20 05:51:34]

This is not safe, it could be an SVG element or just a regular element.

[pals, 2014/05/21 07:55:12]

Changed to isHTMLElement() above.

+        if (HTMLMenuElement* menuElement = element.menuElement()) {

[esprehn, 2014/05/20 05:51:34]

This probably needs to be a RefPtr, the script below can blow away menuElement
and the entire page.

[pals, 2014/05/21 07:55:12]

Done.

+            RefPtr<RelatedEvent> relatedEvent = RelatedEvent::create("show");
+            relatedEvent->setRelatedTarget(node);
+            EventDispatcher::dispatchEvent(menuElement, EventDispatchMediator::create(relatedEvent));

[esprehn, 2014/05/20 05:51:34]

Are you sure it's safe to synchronously execute script here?

[pals, 2014/05/21 07:55:12]

m_menuProvider below which is populated by menu element on receiving this event,
so I am sending this event synchronously. I am not sure of the consequences. Do
you see any problem here? 

+            m_menuProvider = menuElement->getCustomProvider();
+            m_menuProvider->populateContextMenu(m_contextMenu.get());
+        }
+    }
     showContextMenu(event);
 }
 
 void ContextMenuController::showContextMenu(Event* event, PassRefPtr<ContextMenuProvider> menuProvider)
 {
     m_menuProvider = menuProvider;
 
     m_contextMenu = createContextMenu(event);
     if (!m_contextMenu) {
         clearContextMenu();
@@ skipping 36 matching lines @@
     ASSERT(item->type() == ActionType || item->type() == CheckableActionType);
 
     if (item->action() < ContextMenuItemBaseCustomTag || item->action() > ContextMenuItemLastCustomTag)
         return;
 
     ASSERT(m_menuProvider);
     m_menuProvider->contextMenuItemSelected(item);
 }
 
 } // namespace WebCore