Implement contextmenu attribute with basic support of <menu>

Source/core/html/HTMLMenuElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef HTMLMenuElement_h
 #define HTMLMenuElement_h
 
 #include "core/html/HTMLElement.h"
+#include "core/page/ContextMenuProvider.h"
+#include "platform/ContextMenu.h"
+#include "platform/ContextMenuItem.h"
 
 namespace WebCore {
 
+class HTMLMenuElement;
+class CustomContextMenuProvider;
+
 class HTMLMenuElement FINAL : public HTMLElement {
 public:
     static PassRefPtr<HTMLMenuElement> create(Document&);
 
+    void buildCustomProvider();
+    PassRefPtr<CustomContextMenuProvider> getCustomProvider() { return m_menuProvider; }

[esprehn, 2014/05/20 05:51:34]

Getters don't start with "get". Instead you want customProvider() and
ensureCustomProvider() where ensure returns a reference and the regular returns
a pointer.

This shouldn't return PassRefPtr, you're not returning ownership.

[pals, 2014/05/21 07:55:12]

Done.

+    void populateContextMenuItems(HTMLMenuElement* menu, ContextMenu& contextMenu);

[esprehn, 2014/05/20 05:51:34]

You don't need the argument names, they don't add value.

[pals, 2014/05/21 07:55:12]

Done.

+    HTMLElement* getSelectedMenuItem(unsigned menuId);

[esprehn, 2014/05/20 05:51:34]

Getters don't start with "get", selectedMenuItem(menuId)

[pals, 2014/05/21 07:55:12]

Done.

 private:
     explicit HTMLMenuElement(Document&);
+    RefPtr<CustomContextMenuProvider> m_menuProvider;
+    Vector<HTMLElement*> m_menuItems;
 };
 
+class CustomContextMenuProvider FINAL : public ContextMenuProvider {

[esprehn, 2014/05/20 05:51:34]

This doesn't need to be all inline. Give it its own file .h and .cpp file

[pals, 2014/05/21 07:55:12]

Done.

+public:
+    static PassRefPtr<CustomContextMenuProvider> create(HTMLMenuElement* menu, const Vector<ContextMenuItem>& items)
+    {
+        return adoptRef(new CustomContextMenuProvider(menu, items));
+    }
+
+    void disconnect()

[esprehn, 2014/05/20 05:51:34]

What is this for?

[pals, 2014/05/21 07:55:12]

Done. Removed.

+    {
+    }
+
+private:
+    CustomContextMenuProvider(HTMLMenuElement* menu, const Vector<ContextMenuItem>& items)
+        : m_menu(menu)
+        , m_items(items)
+    {
+    }
+
+    virtual ~CustomContextMenuProvider()

[esprehn, 2014/05/20 05:51:34]

These don't need to be inline.

[pals, 2014/05/21 07:55:12]

Done.

+    {
+        contextMenuCleared();
+    }
+
+    virtual void populateContextMenu(ContextMenu* menu) OVERRIDE
+    {
+        for (size_t i = 0; i < m_items.size(); ++i)
+            menu->appendItem(m_items[i]);
+    }
+
+    virtual void contextMenuItemSelected(const ContextMenuItem* item) OVERRIDE
+    {
+        if (m_menu) {
+            if (HTMLElement* element = m_menu->getSelectedMenuItem(item->action()))
+                element->click();
+        }
+    }
+
+    virtual void contextMenuCleared() OVERRIDE
+    {
+        m_items.clear();
+    }
+
+    HTMLMenuElement* m_menu;

[esprehn, 2014/05/20 05:51:34]

Does this need to be a ref ptr? What keeps m_menu alive?

[pals, 2014/05/21 07:55:12]

Done.

+    Vector<ContextMenuItem> m_items;
+};
+
+
 } //namespace
 
 #endif