Source/core/html/HTMLMenuItemElement.idl - Issue 243403006: Implement contextmenu attribute with basic support of <menu>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLMenuItemElement.idl

Issue 243403006: Implement contextmenu attribute with basic support of <menu> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 RuntimeEnabled=ContextMenu,

	7 ] interface HTMLMenuItemElement : HTMLElement {

	8 [Reflect] readonly attribute DOMString type;
	tkent 2014/07/31 06:07:55 Add a test to fast/dom/domstring-attribute-reflect Add a test to fast/dom/domstring-attribute-reflection.html pals 2014/08/01 10:03:07 Done. Show quoted text On 2014/07/31 06:07:55, tkent wrote: > Add a test to fast/dom/domstring-attribute-reflection.html Done.
	9 [Reflect] readonly attribute DOMString label;
	tkent 2014/07/31 06:07:55 Ditto. Ditto. pals 2014/08/01 10:03:08 Done. Show quoted text On 2014/07/31 06:07:55, tkent wrote: > Ditto. Done.
	10 [Reflect] readonly attribute boolean disabled;
	tkent 2014/07/31 06:07:55 Add a test to fast/dom/boolean-attribute-reflectio Add a test to fast/dom/boolean-attribute-reflection.html pals 2014/08/01 10:03:08 Done. Show quoted text On 2014/07/31 06:07:55, tkent wrote: > Add a test to fast/dom/boolean-attribute-reflection.html Done.
	11 [Reflect] readonly attribute boolean checked;
	tkent 2014/07/31 06:07:56 Ditto. Ditto. pals 2014/08/01 10:03:07 Done. Show quoted text On 2014/07/31 06:07:56, tkent wrote: > Ditto. Done.
	12 [Reflect] readonly attribute boolean default;
	tkent 2014/07/31 06:07:56 Ditto. Ditto. pals 2014/08/01 10:03:07 Done. Show quoted text On 2014/07/31 06:07:56, tkent wrote: > Ditto. Done.
	13 };
	tkent 2014/07/31 06:07:56 Add a FIXME comment about unimplemented IDL attrib Add a FIXME comment about unimplemented IDL attributes. pals 2014/08/01 10:03:08 Done. Show quoted text On 2014/07/31 06:07:56, tkent wrote: > Add a FIXME comment about unimplemented IDL attributes. Done.
OLD	NEW

« Source/core/html/HTMLMenuItemElement.cpp ('K') | « Source/core/html/HTMLMenuItemElement.cpp ('k') | Source/core/html/HTMLTagNames.in » ('j') | Source/core/page/ContextMenuController.h » ('J')