Source/core/events/RelatedEvent.idl - Issue 243403006: Implement contextmenu attribute with basic support of <menu>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/events/RelatedEvent.idl

Issue 243403006: Implement contextmenu attribute with basic support of <menu> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 EventConstructor,
	tkent 2014/07/31 06:07:55 Need a layout test for constructor. Need a layout test for constructor. pals 2014/08/01 10:03:07 Rebased LayoutTests/webexposed/global-constructors Show quoted text On 2014/07/31 06:07:55, tkent wrote: > Need a layout test for constructor. Rebased LayoutTests/webexposed/global-constructors-listing.html. Do you mean the same? tkent 2014/08/04 02:26:12 No. global-constructors-list.html just lists cons Show quoted text On 2014/08/01 10:03:07, sanjoy.pal wrote: > On 2014/07/31 06:07:55, tkent wrote: > > Need a layout test for constructor. > Rebased LayoutTests/webexposed/global-constructors-listing.html. > Do you mean the same? No. global-constructors-list.html just lists constructors. We need a test of RelatedEvent constructor behavior. See LayoutTests/fast/event/constructors/. pals 2014/08/04 08:58:26 Added tests. Show quoted text On 2014/08/04 02:26:12, tkent wrote: > On 2014/08/01 10:03:07, sanjoy.pal wrote: > > On 2014/07/31 06:07:55, tkent wrote: > > > Need a layout test for constructor. > > Rebased LayoutTests/webexposed/global-constructors-listing.html. > > Do you mean the same? > > No. global-constructors-list.html just lists constructors. We need a test of > RelatedEvent constructor behavior. See LayoutTests/fast/event/constructors/. Added tests.
	7 RuntimeEnabled=ContextMenu,

	8 ] interface RelatedEvent : Event {

	9 [InitializedByEventConstructor] readonly attribute EventTarget relatedTarget ;

	10 };

	11

OLD	NEW

« no previous file with comments | « Source/core/events/RelatedEvent.cpp ('k') | Source/core/html/HTMLAttributeNames.in » ('j') | Source/core/html/HTMLElement.h » ('J')