Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2581)

Unified Diff: chrome/browser/resources/vr_shell/vr_shell_ui.js

Issue 2434013002: Implement a means of letting native VR Shell control the HTML UI. (Closed)
Patch Set: Impelement a means of letting native VR Shell control the HTML UI. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/vr_shell/vr_shell_ui.js
diff --git a/chrome/browser/resources/vr_shell/vr_shell_ui.js b/chrome/browser/resources/vr_shell/vr_shell_ui.js
index bafc81153efca8ba01584a4cfba8fd5c3107d921..36e1a057b962c878b1a1725874a772102cbe4e88 100644
--- a/chrome/browser/resources/vr_shell/vr_shell_ui.js
+++ b/chrome/browser/resources/vr_shell/vr_shell_ui.js
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-var vrShellUi = (function() {
+cr.define('chrome.vrShellUi', function() {
bshe 2016/10/19 21:02:40 now that you have cr.js, perhaps do the same for v
cjgrant 2016/10/20 15:25:39 Why do that if native is calling only to the UI?
bshe 2016/10/20 18:07:48 I don't think it is related to native. I believe c
cjgrant 2016/10/20 19:59:58 As discussed, removed use of cr.define().
'use strict';
var scene = new ui.Scene();
@@ -112,9 +112,13 @@ var vrShellUi = (function() {
api.domLoaded();
}
+ function command(dict) {
mthiesse 2016/10/19 18:04:10 Put in a TODO to implement this?
+ }
+
return {
initialize: initialize,
+ command: command,
};
-})();
+});
-document.addEventListener('DOMContentLoaded', vrShellUi.initialize);
+document.addEventListener('DOMContentLoaded', chrome.vrShellUi.initialize);

Powered by Google App Engine
This is Rietveld 408576698