Implement a means of letting native VR Shell control the HTML UI.

chrome/browser/resources/vr_shell/vr_shell_ui.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-var vrShellUi = (function() {
+cr.define('chrome.vrShellUi', function() {

[bshe, 2016/10/19 21:02:40]

now that you have cr.js, perhaps do the same for vr_shell_ui_api and
vr_shell_ui_scene?

[cjgrant, 2016/10/20 15:25:39]

Why do that if native is calling only to the UI?  We don't need to expose
api/scene stuff to native, as they are helper libraries for the UI.  Let me know
if I'm missing something.

[bshe, 2016/10/20 18:07:48]

I don't think it is related to native. I believe cr.define is just a helper to
define a namespace. So you don't need to chrome= {} an dchrome.vrShellUi = {}.
It would be nice to have all the js under the same namespace to avoid potential
conflict. Although unlikely this is going to happen. So if you prefer to leave
it this way, I am fine.
I am fine.

[cjgrant, 2016/10/20 19:59:58]

As discussed, removed use of cr.define().

   'use strict';
 
   var scene = new ui.Scene();
   var uiElements = [];
 
   class DomUiElement {
     constructor(domId) {
       var domElement = document.querySelector(domId);
       var style = window.getComputedStyle(domElement);
 
@@ skipping 89 matching lines @@
       scene.updateElement(element.uiElementId, update);
     }
 
     scene.flush();
   }
 
   function domLoaded() {
     api.domLoaded();
   }
 
+  function command(dict) {

[mthiesse, 2016/10/19 18:04:10]

Put in a TODO to implement this?

+  }
+
   return {
     initialize: initialize,
+    command: command,
   };
-})();
+});
 
-document.addEventListener('DOMContentLoaded', vrShellUi.initialize);
+document.addEventListener('DOMContentLoaded', chrome.vrShellUi.initialize);