Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 2433953002: Disable flaky ExtensionApiTest.TabsNoPermissions on Linux. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/prefs/incognito_mode_prefs.h" 8 #include "chrome/browser/prefs/incognito_mode_prefs.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 } 214 }
215 215
216 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabsOnCreated) { 216 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabsOnCreated) {
217 ASSERT_TRUE(RunExtensionTest("tabs/on_created")) << message_; 217 ASSERT_TRUE(RunExtensionTest("tabs/on_created")) << message_;
218 } 218 }
219 219
220 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabsOnUpdated) { 220 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabsOnUpdated) {
221 ASSERT_TRUE(RunExtensionTest("tabs/on_updated")) << message_; 221 ASSERT_TRUE(RunExtensionTest("tabs/on_updated")) << message_;
222 } 222 }
223 223
224 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabsNoPermissions) { 224 // Flaky on Linux. http://crbug.com/657376.
225 #if defined(OS_LINUX)
226 #define MAYBE_TabsNoPermissions DISABLED_TabsNoPermissions
227 #else
228 #define MAYBE_TabsNoPermissions TabsNoPermissions
229 #endif
230 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_TabsNoPermissions) {
225 host_resolver()->AddRule("a.com", "127.0.0.1"); 231 host_resolver()->AddRule("a.com", "127.0.0.1");
226 ASSERT_TRUE(StartEmbeddedTestServer()); 232 ASSERT_TRUE(StartEmbeddedTestServer());
227 ASSERT_TRUE(RunExtensionTest("tabs/no_permissions")) << message_; 233 ASSERT_TRUE(RunExtensionTest("tabs/no_permissions")) << message_;
228 } 234 }
229 235
230 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, HostPermission) { 236 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, HostPermission) {
231 host_resolver()->AddRule("a.com", "127.0.0.1"); 237 host_resolver()->AddRule("a.com", "127.0.0.1");
232 ASSERT_TRUE(StartEmbeddedTestServer()); 238 ASSERT_TRUE(StartEmbeddedTestServer());
233 239
234 ASSERT_TRUE(RunExtensionTest("tabs/host_permission")) << message_; 240 ASSERT_TRUE(RunExtensionTest("tabs/host_permission")) << message_;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 << message_; 276 << message_;
271 } 277 }
272 278
273 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OnUpdatedDiscardedState) { 279 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OnUpdatedDiscardedState) {
274 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "discarded.html")) << message_; 280 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "discarded.html")) << message_;
275 } 281 }
276 282
277 // Adding a new test? Awesome. But API tests are the old hotness. The new 283 // Adding a new test? Awesome. But API tests are the old hotness. The new
278 // hotness is extension_function_test_utils. See tabs_test.cc for an example. 284 // hotness is extension_function_test_utils. See tabs_test.cc for an example.
279 // We are trying to phase out many uses of API tests as they tend to be flaky. 285 // We are trying to phase out many uses of API tests as they tend to be flaky.
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698