Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 2433933003: Fix Double.pow() for arm and mips (Closed)
Patch Set: Cleanup Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_mips.cc
diff --git a/runtime/vm/intermediate_language_mips.cc b/runtime/vm/intermediate_language_mips.cc
index d61337d52f38a965917fbdb336448c81a91d5052..793c1b43d93f959a7a8032aba7ec00fd1deb4eed 100644
--- a/runtime/vm/intermediate_language_mips.cc
+++ b/runtime/vm/intermediate_language_mips.cc
@@ -4580,15 +4580,15 @@ static void InvokeDoublePow(FlowGraphCompiler* compiler,
__ Bind(&try_sqrt);
// Before calling pow, check if we could use sqrt instead of pow.
- __ LoadImmediate(result, kPosInfinity);
- // base == Infinity -> call pow;
+ __ LoadImmediate(result, kNegInfinity);
+ // base == -Infinity -> call pow;
__ ceqd(base, result);
Label do_pow;
__ bc1t(&do_pow);
// exponent == 0.5 ?
__ LoadImmediate(result, 0.5);
- __ ceqd(base, result);
+ __ ceqd(exp, result);
__ bc1f(&do_pow);
// base == 0 -> return 0;
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698