Issue 2433863002: Merged: [turbofan] Fix return value of Array.prototype.push.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2433863002: Merged: [turbofan] Fix return value of Array.prototype.push. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer

Modified:
4 years, 2 months ago

Reviewers:
Jarin

CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan

Target Ref:
refs/pending/branch-heads/5.5

Project:
v8

Visibility:
Public.

Merged: [turbofan] Fix return value of Array.prototype.push. Revision: 85844420a2cab6e8f4582e462b28f7f86db2d651 BUG=chromium:656037 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=jarin@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/fa372a9a86597f71b6b7785250ccee473adaa83a

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -7 lines)			Patch
M	src/compiler/js-builtin-reducer.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/typer.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-656037.js	View	1 chunk	+5 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...

4 years, 2 months ago (2016-10-19 07:22:37 UTC) #2

Benedikt Meurer

4 years, 2 months ago (2016-10-19 07:24:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fa372a9a86597f71b6b7785250ccee473adaa83a.