third_party/WebKit/Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp - Issue 2433773006: Remove ExecutionContext::activeDOMObjectsAreStopped()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp

Issue 2433773006: Remove ExecutionContext::activeDOMObjectsAreStopped()

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp b/third_party/WebKit/Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp

index 1afd8c5e014d80fb3548414ea37def0cf6495d39..18f8b4afc73c27608be9118e491b8cf43dd47ac1 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp

@@ -22,8 +22,7 @@ void PushPermissionStatusCallbacks::onSuccess(WebPushPermissionStatus status) {

}

void PushPermissionStatusCallbacks::onError(const WebPushError& error) {

- if (!m_resolver->getExecutionContext() ||

- m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())

+ if (!m_resolver->getExecutionContext())

return;

m_resolver->reject(PushError::take(m_resolver.get(), error));

}