third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp - Issue 2433773006: Remove ExecutionContext::activeDOMObjectsAreStopped()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp

Issue 2433773006: Remove ExecutionContext::activeDOMObjectsAreStopped()

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp ('k') | third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp b/third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp

index a7b060e6e63dcc14560fa3519e90583b808a202b..efe7c3f3bcb889e8da7f3ea94fb3757a12468ebf 100644

--- a/third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp

@@ -42,8 +42,7 @@ SetSinkIdCallbacks::SetSinkIdCallbacks(ScriptPromiseResolver* resolver,

SetSinkIdCallbacks::~SetSinkIdCallbacks() {}

void SetSinkIdCallbacks::onSuccess() {

- if (!m_resolver->getExecutionContext() ||

- m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())

+ if (!m_resolver->getExecutionContext())

return;

HTMLMediaElementAudioOutputDevice& aodElement =

@@ -53,8 +52,7 @@ void SetSinkIdCallbacks::onSuccess() {

}

void SetSinkIdCallbacks::onError(WebSetSinkIdError error) {

- if (!m_resolver->getExecutionContext() ||

- m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())

+ if (!m_resolver->getExecutionContext())

return;

m_resolver->reject(ToException(error));