Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 2433773006: Remove ExecutionContext::activeDOMObjectsAreStopped()
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h b/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h
index cea8b7e6bd1d936a692731a1f1ceab50e605fc9c..cc22fccddb9837bd6ec4800215306e97a621a318 100644
--- a/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h
+++ b/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h
@@ -138,8 +138,7 @@ class CallbackPromiseAdapterInternal {
: Base<S, T>(resolver) {}
void onSuccess(typename S::WebType result) override {
ScriptPromiseResolver* resolver = this->resolver();
- if (!resolver->getExecutionContext() ||
- resolver->getExecutionContext()->activeDOMObjectsAreStopped())
+ if (!resolver->getExecutionContext())
return;
resolver->resolve(S::take(resolver, std::move(result)));
}
@@ -152,8 +151,7 @@ class CallbackPromiseAdapterInternal {
: Base<CallbackPromiseAdapterTrivialWebTypeHolder<void>, T>(resolver) {}
void onSuccess() override {
ScriptPromiseResolver* resolver = this->resolver();
- if (!resolver->getExecutionContext() ||
- resolver->getExecutionContext()->activeDOMObjectsAreStopped())
+ if (!resolver->getExecutionContext())
return;
resolver->resolve();
}
@@ -165,8 +163,7 @@ class CallbackPromiseAdapterInternal {
: OnSuccess<S, T>(resolver) {}
void onError(typename T::WebType e) override {
ScriptPromiseResolver* resolver = this->resolver();
- if (!resolver->getExecutionContext() ||
- resolver->getExecutionContext()->activeDOMObjectsAreStopped())
+ if (!resolver->getExecutionContext())
return;
ScriptState::Scope scope(resolver->getScriptState());
resolver->reject(T::take(resolver, std::move(e)));
@@ -181,8 +178,7 @@ class CallbackPromiseAdapterInternal {
resolver) {}
void onError() override {
ScriptPromiseResolver* resolver = this->resolver();
- if (!resolver->getExecutionContext() ||
- resolver->getExecutionContext()->activeDOMObjectsAreStopped())
+ if (!resolver->getExecutionContext())
return;
resolver->reject();
}

Powered by Google App Engine
This is Rietveld 408576698