Chromium Code Reviews

Issue 24337005: Make Heap::AllocateRawFixedArray methods private. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 2 months ago
Reviewers:
Hannes Payer (out of office)
CC:
v8-dev
Visibility:
Public.

Description

Make Heap::AllocateRawFixedArray methods private. R=hpayer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16959

Patch Set 1 #

Patch Set 2 : Minor cleanup. #

Patch Set 3 : Another minor cleanup. #

Unified diffs Side-by-side diffs Stats (+29 lines, -52 lines)
M src/heap.h View 3 chunks +12 lines, -9 lines 0 comments
M src/heap.cc View 4 chunks +12 lines, -35 lines 0 comments
M src/runtime.cc View 1 chunk +5 lines, -8 lines 0 comments

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-09-24 15:16:10 UTC) #1
Hannes Payer (out of office)
LGTM
7 years, 2 months ago (2013-09-26 09:26:07 UTC) #2
Michael Starzinger
7 years, 2 months ago (2013-09-26 09:37:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r16959 (presubmit successful).

Powered by Google App Engine