Reduce buggy usage of the registry controlled domain service.

content/renderer/webpublicsuffixlist_impl.cc

Index: content/renderer/webpublicsuffixlist_impl.cc
diff --git a/content/renderer/webpublicsuffixlist_impl.cc b/content/renderer/webpublicsuffixlist_impl.cc
index e1e00c22be28c7c42184e38d29999cb81d9f7308..36d0a395c773c16f53206a330f26adb6a4337893 100644
--- a/content/renderer/webpublicsuffixlist_impl.cc
+++ b/content/renderer/webpublicsuffixlist_impl.cc
@@ -13,10 +13,11 @@ WebPublicSuffixListImpl::~WebPublicSuffixListImpl() {
 
 size_t WebPublicSuffixListImpl::getPublicSuffixLength(
     const blink::WebString& host) {
-  size_t result = net::registry_controlled_domains::GetRegistryLength(
-      host.utf8(),
-      net::registry_controlled_domains::INCLUDE_UNKNOWN_REGISTRIES,
-      net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);
+  size_t result =
+      net::registry_controlled_domains::GetCanonicalHostRegistryLength(

[Peter Kasting, 2016/10/22 05:04:18]

Nit: Kinda makes me nervous that this assumes |host| is canonical.  At the least
we should probably rename |host| to |canonical_host| and write that it must be
canonical in the declaration comment?  I wish OriginAccessEntry had more
comments to indicate that it was only expected to be constructed with
canonicalized hosts or something?

[brettw, 2016/10/24 21:45:23]

I added the comment, there is no parameter name because it's WebKit :(

+          host.utf8(),
+          net::registry_controlled_domains::INCLUDE_UNKNOWN_REGISTRIES,
+          net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);
   return result ? result : host.length();
 }