Reduce buggy usage of the registry controlled domain service.

components/google/core/browser/google_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/google/core/browser/google_util.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
@@ skipping 15 matching lines @@
 // Only use Link Doctor on official builds.  It uses an API key, too, but
 // seems best to just disable it, for more responsive error pages and to reduce
 // server load.
 #if defined(GOOGLE_CHROME_BUILD)
 #define LINKDOCTOR_SERVER_REQUEST_URL "https://www.googleapis.com/rpc"
 #else
 #define LINKDOCTOR_SERVER_REQUEST_URL ""
 #endif
 
 
+namespace google_util {
+
 // Helpers --------------------------------------------------------------------
 
 namespace {
 
 bool gUseMockLinkDoctorBaseURLForTesting = false;
 
 bool IsPathHomePageBase(base::StringPiece path) {
   return (path == "/") || (path == "/webhp");
 }
 
-// True if |host| is "[www.]<domain_in_lower_case>.<TLD>" with a valid TLD. If
-// |subdomain_permission| is ALLOW_SUBDOMAIN, we check against host
-// "*.<domain_in_lower_case>.<TLD>" instead.
+// True if the given canonical |host| is "[www.]<domain_in_lower_case>.<TLD>"
+// with a valid TLD. If |subdomain_permission| is ALLOW_SUBDOMAIN, we check
+// against host "*.<domain_in_lower_case>.<TLD>" instead.
 bool IsValidHostName(base::StringPiece host,
                      base::StringPiece domain_in_lower_case,
-                     google_util::SubdomainPermission subdomain_permission) {
-  size_t tld_length = net::registry_controlled_domains::GetRegistryLength(
-      host,
-      net::registry_controlled_domains::EXCLUDE_UNKNOWN_REGISTRIES,
-      net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES);
+                     SubdomainPermission subdomain_permission) {
+  size_t tld_length =
+      net::registry_controlled_domains::GetRegistryLengthForCanonicalHost(
+          host,
+          net::registry_controlled_domains::EXCLUDE_UNKNOWN_REGISTRIES,
+          net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES);
   if ((tld_length == 0) || (tld_length == std::string::npos))
     return false;
 
   // Removes the tld and the preceding dot.
   base::StringPiece host_minus_tld =
       host.substr(0, host.length() - tld_length - 1);
   if (base::LowerCaseEqualsASCII(host_minus_tld, domain_in_lower_case))
     return true;
 
-  if (subdomain_permission == google_util::ALLOW_SUBDOMAIN) {
+  if (subdomain_permission == ALLOW_SUBDOMAIN) {
     std::string dot_domain(".");
     domain_in_lower_case.AppendToString(&dot_domain);
     return base::EndsWith(host_minus_tld, dot_domain,
                           base::CompareCase::INSENSITIVE_ASCII);
   }
 
   std::string www_domain("www.");
   domain_in_lower_case.AppendToString(&www_domain);
   return base::LowerCaseEqualsASCII(host_minus_tld, www_domain);
 }
 
 // True if |url| is a valid URL with HTTP or HTTPS scheme. If |port_permission|
 // is DISALLOW_NON_STANDARD_PORTS, this also requires |url| to use the standard
 // port for its scheme (80 for HTTP, 443 for HTTPS).
-bool IsValidURL(const GURL& url, google_util::PortPermission port_permission) {
+bool IsValidURL(const GURL& url, PortPermission port_permission) {
   return url.is_valid() && url.SchemeIsHTTPOrHTTPS() &&
       (url.port().empty() ||
-       (port_permission == google_util::ALLOW_NON_STANDARD_PORTS));
+       (port_permission == ALLOW_NON_STANDARD_PORTS));
+}
+
+bool IsCanonicalHostGoogleHostname(base::StringPiece canonical_host,
+                                   SubdomainPermission subdomain_permission) {
+  const GURL& base_url(CommandLineGoogleBaseURL());

[brettw, 2016/10/19 20:16:36]

This is separated out from below to avoid double-canonicalizing in the GURL case
(IsGoogleDomainUrl).

+  if (base_url.is_valid() && (canonical_host == base_url.host_piece()))
+    return true;
+
+  return IsValidHostName(canonical_host, "google", subdomain_permission);
 }
 
 }  // namespace
 
-
-namespace google_util {
-
 // Global functions -----------------------------------------------------------
 
 bool HasGoogleSearchQueryParam(base::StringPiece str) {
   url::Component query(0, static_cast<int>(str.length())), key, value;
   while (url::ExtractQueryKeyValue(str.data(), &query, &key, &value)) {
     if (value.is_nonempty()) {
       base::StringPiece key_str = str.substr(key.begin, key.len);
       if (key_str == "q" || key_str == "as_q")
         return true;
     }
@@ skipping 72 matching lines @@
 
 bool StartsWithCommandLineGoogleBaseURL(const GURL& url) {
   const GURL& base_url(CommandLineGoogleBaseURL());
   return base_url.is_valid() &&
          base::StartsWith(url.possibly_invalid_spec(), base_url.spec(),
                           base::CompareCase::SENSITIVE);
 }
 
 bool IsGoogleHostname(base::StringPiece host,
                       SubdomainPermission subdomain_permission) {
-  const GURL& base_url(CommandLineGoogleBaseURL());
-  if (base_url.is_valid() && (host == base_url.host_piece()))
-    return true;
-
-  return IsValidHostName(host, "google", subdomain_permission);
+  url::CanonHostInfo host_info;
+  return IsCanonicalHostGoogleHostname(net::CanonicalizeHost(host, &host_info),
+                                       subdomain_permission);
 }
 
 bool IsGoogleDomainUrl(const GURL& url,
                        SubdomainPermission subdomain_permission,
                        PortPermission port_permission) {
   return IsValidURL(url, port_permission) &&
-      IsGoogleHostname(url.host(), subdomain_permission);
+      IsCanonicalHostGoogleHostname(url.host_piece(), subdomain_permission);
 }
 
 bool IsGoogleHomePageUrl(const GURL& url) {
   // First check to see if this has a Google domain.
   if (!IsGoogleDomainUrl(url, DISALLOW_SUBDOMAIN, DISALLOW_NON_STANDARD_PORTS))
     return false;
 
   // Make sure the path is a known home page path.
   base::StringPiece path(url.path_piece());
   return IsPathHomePageBase(path) ||
@@ skipping 18 matching lines @@
 }
 
 bool IsYoutubeDomainUrl(const GURL& url,
                         SubdomainPermission subdomain_permission,
                         PortPermission port_permission) {
   return IsValidURL(url, port_permission) &&
       IsValidHostName(url.host_piece(), "youtube", subdomain_permission);
 }
 
 }  // namespace google_util