third_party/WebKit/public/platform/WebPublicSuffixList.h - Issue 2433583002: Reduce buggy usage of the registry controlled domain service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/WebPublicSuffixList.h

Issue 2433583002: Reduce buggy usage of the registry controlled domain service. (Closed)

Patch Set: Review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 19 matching lines...) Expand all Loading...
30	30

31 #ifndef WebPublicSuffixList_h	31 #ifndef WebPublicSuffixList_h

32 #define WebPublicSuffixList_h	32 #define WebPublicSuffixList_h

33	33

34 #include "public/platform/WebString.h"	34 #include "public/platform/WebString.h"

35	35

36 namespace blink {	36 namespace blink {

37	37

38 class WebPublicSuffixList {	38 class WebPublicSuffixList {

39 public:	39 public:

	40 // The host name must be in canonical form.

40 virtual size_t getPublicSuffixLength(const WebString&) = 0;	41 virtual size_t getPublicSuffixLength(const WebString&) = 0;
	Peter Kasting 2016/10/25 01:33:33 Nit: In WebKit style, it's OK to add a param name Nit: In WebKit style, it's OK to add a param name here as long as the name is not obvious/redundant with the function name. Here, I think it's perfectly legal to call this canonical_hostname or whatever. brettw 2016/10/25 20:28:18 Done. Show quoted text On 2016/10/25 01:33:33, Peter Kasting wrote: > Nit: In WebKit style, it's OK to add a param name here as long as the name is > not obvious/redundant with the function name. Here, I think it's perfectly > legal to call this canonical_hostname or whatever. Done.
41	42

42 protected:	43 protected:

43 virtual ~WebPublicSuffixList() {}	44 virtual ~WebPublicSuffixList() {}

44 };	45 };

45	46

46 } // namespace blink	47 } // namespace blink

47	48

48 #endif // WebPublicSuffixList_h	49 #endif // WebPublicSuffixList_h

OLD	NEW

« net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc ('K') | « net/cert/x509_certificate.cc ('k') | url/url_canon.h » ('j') | url/url_canon.h » ('J')