Chromad: added AD Join ui, authpolicy_client

chromeos/dbus/fake_auth_policy_client.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_DBUS_FAKE_AUTH_POLICY_CLIENT_H_
+#define CHROMEOS_DBUS_FAKE_AUTH_POLICY_CLIENT_H_
+
+#include <string>
+
+#include "chromeos/dbus/auth_policy_client.h"
+
+namespace chromeos {
+
+class CHROMEOS_EXPORT FakeAuthPolicyClient : public AuthPolicyClient {
+ public:
+  FakeAuthPolicyClient();
+  ~FakeAuthPolicyClient() override;
+
+  void Init(dbus::Bus* bus) override;

[xiyuan, 2016/10/26 22:03:17]

nit: // AuthPolicyClient:

[hashimoto, 2016/10/27 02:26:07]

As xiyuan said, please add comments to make it clear which class you are
overriding.

Actually, Init() is overriding DBusClient so it should say DBusClient while
JoinADDomain is overriding AuthPolicyClient.

[Roman Sorokin (ftl), 2016/10/27 13:10:46]

Done.

[Roman Sorokin (ftl), 2016/10/27 13:10:46]

Done.

+

[xiyuan, 2016/10/26 22:03:17]

nit: nuke the empty line?

[Roman Sorokin (ftl), 2016/10/27 13:10:46]

Done.

+  void JoinADDomain(const std::string& machine_name,
+                    const std::string& user,
+                    int password_fd,
+                    const JoinCallback& callback) override;
+
+ protected:

[xiyuan, 2016/10/26 22:03:17]

private: ?

[Roman Sorokin (ftl), 2016/10/27 13:10:46]

Done.

+  DISALLOW_COPY_AND_ASSIGN(FakeAuthPolicyClient);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_DBUS_FAKE_AUTH_POLICY_CLIENT_H_