chrome/browser/resources/chromeos/login/offline_ad_login.html - Issue 2433363004: Chromad: added AD Join ui, authpolicy_client

Side by Side Diff: chrome/browser/resources/chromeos/login/offline_ad_login.html

Issue 2433363004: Chromad: added AD Join ui, authpolicy_client (Closed)

Patch Set: Not close password_fd in AuthPolicyClient Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/chromeos/policy/enrollment_config.h ('K') | « chrome/browser/resources/chromeos/login/custom_elements_oobe.js ('k') | chrome/browser/resources/chromeos/login/offline_ad_login.js » ('j') | chrome/browser/resources/chromeos/login/offline_ad_login.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	2 Use of this source code is governed by a BSD-style license that can be

	3 found in the LICENSE file. -->

	4

	5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	7

	8 <!--

	9 Offline UI for the AD Domain joining and User authentication.

	10

	11 Example:

	12 <offline-ad-login show-machine-input> </offline-ad-login>

	13

	14 Attributes:

	15 'showMachineInput' - If the input of the machine name should be shown.
	xiyuan 2016/10/26 22:03:16 nit: If -> Whether nit: If -> Whether Roman Sorokin (ftl) 2016/10/27 13:10:45 Done. Show quoted text On 2016/10/26 22:03:16, xiyuan wrote: > nit: If -> Whether Done.
	16 Used for domain joining.
	xiyuan 2016/10/26 22:03:16 nit: Indent 4 more spaces or align with the beginn nit: Indent 4 more spaces or align with the beginning of "If the input..." Roman Sorokin (ftl) 2016/10/27 13:10:45 Done. Show quoted text On 2016/10/26 22:03:16, xiyuan wrote: > nit: Indent 4 more spaces or align with the beginning of "If the input..." Done.
	17 'realm' - The AD realm the device is managed by.

	18 'userRealm' - autocomplete realm for the user input.
	xiyuan 2016/10/26 22:03:16 nit: autocomplete -> Autocomplete nit: autocomplete -> Autocomplete Roman Sorokin (ftl) 2016/10/27 13:10:45 Done. Show quoted text On 2016/10/26 22:03:16, xiyuan wrote: > nit: autocomplete -> Autocomplete Done.
	19

	20 Events:

	21 'authCompleted' - fired when user enters login and password. Fires with an
	xiyuan 2016/10/26 22:03:16 nit: fired -> Fired, or keep the lower case and fi nit: fired -> Fired, or keep the lower case and fix other places where we start with uppercase. We should be consistent. Roman Sorokin (ftl) 2016/10/27 13:10:45 Done. Show quoted text On 2016/10/26 22:03:16, xiyuan wrote: > nit: fired -> Fired, or keep the lower case and fix other places where we start > with uppercase. We should be consistent. Done.
	22 argument \|credentials\| which contains.

	23 \|credentials\| = { 'machineName': <machine name input>,

	24 'username': <username> (UPN),

	25 'password': <typed password> }

	26 Methods:

	27 'focus' - focuses current input (user input or password input);

	28 'setUser' - accepts arguments \|user\| and \|machineName\|

	29 -->

	30 <dom-module name="offline-ad-login">

	31 <link rel="stylesheet" href="offline_gaia.css">

	32 <template>

	33 <gaia-card id="gaiaCard" class="fit">
	xiyuan 2016/10/26 22:03:16 nit: wrong indent nit: wrong indent Roman Sorokin (ftl) 2016/10/27 13:10:45 Done. Show quoted text On 2016/10/26 22:03:16, xiyuan wrote: > nit: wrong indent Done.
	34 <div class="header flex vertical layout end-justified start">

	35 <h1 id="welcomeMsg" class="welcome-message">[[adWelcomeMessage]]

	36 </h1>

	37 </div>

	38 <div class="footer flex vertical layout justified">

	39 <gaia-input-form on-submit="onSubmit_"

	40 disabled="[[disabled]]"

	41 i18n-values="button-text:offlineLoginNextBtn">

	42 <gaia-input id="machineNameInput" required hidden="[[!showMachineI nput]]"
	xiyuan 2016/10/26 22:03:16 What does it mean when the field is required and a What does it mean when the field is required and also hidden? xiyuan 2016/10/26 22:03:16 nit: wrap to fit in 80 chars per line nit: wrap to fit in 80 chars per line Roman Sorokin (ftl) 2016/10/27 13:10:45 Right! It's required if it's shown. Added check in Show quoted text On 2016/10/26 22:03:16, xiyuan wrote: > What does it mean when the field is required and also hidden? Right! It's required if it's shown. Added check in .js Roman Sorokin (ftl) 2016/10/27 13:10:45 Done. Show quoted text On 2016/10/26 22:03:16, xiyuan wrote: > nit: wrap to fit in 80 chars per line Done.
	43 i18n-values="label:oauthEnrollADMachineNameInput">

	44 </gaia-input>

	45 <gaia-input id="userInput" type="email" required

	46 domain="[[userRealm]]"

	47 i18n-values="error:offlineLoginInvalidEmail;

	48 label:ADLoginUser">

	49 </gaia-input>

	50 <gaia-input id="passwordInput" type="password" required

	51 i18n-values="error:offlineLoginInvalidPassword;

	52 label:ADLoginPassword">

	53 </gaia-input>

	54 </gaia-input-form>

	55 <img src="chrome://theme/IDR_LOGO_GOOGLE_COLOR_90"

	56 class="self-center" alt="">

	57 </div>

	58 </gaia-card>

	59 </template>

	60 </dom-module>

	61

OLD	NEW