Chromad: added AD Join ui, authpolicy_client

chromeos/dbus/authpolicy_client.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_DBUS_AUTHPOLICY_CLIENT_H_

[hashimoto, 2016/10/26 06:11:12]

The file name should be auth_policy_client.h
The same goes for other files and variable names.

[Roman Sorokin (ftl), 2016/10/26 18:45:35]

Done.

+#define CHROMEOS_DBUS_AUTHPOLICY_CLIENT_H_
+
+#include <string>
+
+#include "base/callback.h"
+#include "chromeos/chromeos_export.h"
+#include "chromeos/dbus/dbus_client.h"
+
+namespace chromeos {
+
+// AuthPolicyClient is used to communicate with the org.chromium.AuthPolicy
+// sevice. All method should be called from the origin thread (UI thread) which
+// initializes the DBusThreadManager instance.
+class CHROMEOS_EXPORT AuthPolicyClient : public DBusClient {
+ public:
+  typedef base::Callback<void(int error_code)> JoinCallback;
+
+  ~AuthPolicyClient() override;
+
+  // Factory function, creates a new instance and returns ownership.
+  // For normal usage, access the singleton via DBusThreadManager::Get().
+  static AuthPolicyClient* Create();
+
+  // Calls JoinADDomain. Uses |machine_name| to join it to the domain. |user|,

[hashimoto, 2016/10/26 06:11:12]

Could you add some words to make it clear what "joining AD domain" means?
Especially, I don't think most Chromium developers can understand the
abbreviation "AD".

[Roman Sorokin (ftl), 2016/10/26 18:45:35]

Can't do that for now. Added TODO to change it in the future.

+  // |password| are credentials of the AD user which have right to join the
+  // domain. |callback| is called after the method call succeeds.
+  virtual void JoinADDomain(const std::string& machine_name,
+                            const std::string& user,
+                            const std::string& password,
+                            const JoinCallback& callback) = 0;
+
+ protected:
+  // Create() should be used instead.
+  AuthPolicyClient();
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AuthPolicyClient);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_DBUS_AUTHPOLICY_CLIENT_H_