Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2433343002: Only build libsrtp tests if a build flag is set (Closed)

Created:
4 years, 2 months ago by mattdr-at-chromium
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only build libsrtp tests if a build flag is set After the most recent setback (Android targets break if you change their output_dir) I've decided enumerating the configurations where these tests can build isn't worth the effort. They're not run, anyway. Let clients ask for them if they want them. BUG=webrtc:6376 R=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libsrtp/+/71692eaab2a06bbd87a551614a8791c7caa7e266

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M BUILD.gn View 2 chunks +7 lines, -8 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
mattdr-at-chromium
https://chromiumcodereview.appspot.com/2436913003/ (╯°□°)╯︵ ┻━┻ Please land if lgty. Thanks as always.
4 years, 2 months ago (2016-10-20 10:42:44 UTC) #2
mattdr-at-chromium
https://chromiumcodereview.appspot.com/2433343002/diff/1/BUILD.gn File BUILD.gn (left): https://chromiumcodereview.appspot.com/2433343002/diff/1/BUILD.gn#oldcode121 BUILD.gn:121: group("srtp_tests") { I decided there wasn't value in providing ...
4 years, 2 months ago (2016-10-20 10:45:10 UTC) #3
kjellander_chromium
lgtm (I will land) Sorry you're feeling all the pain with multi-repo development here (especially ...
4 years, 2 months ago (2016-10-20 11:37:36 UTC) #4
kjellander_chromium
4 years, 2 months ago (2016-10-20 11:38:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71692eaab2a06bbd87a551614a8791c7caa7e266 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698