Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 243333008: SK_API-export SkBBHFactory & friends. (Closed)

Created:
6 years, 8 months ago by f(malita)
Modified:
6 years, 8 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M include/core/SkBBHFactory.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
f(malita)
6 years, 8 months ago (2014-04-21 14:58:27 UTC) #1
reed1
lgtm -- assuming rob doesn't object -- but he's out today
6 years, 8 months ago (2014-04-21 18:28:00 UTC) #2
f(malita)
On 2014/04/21 18:28:00, reed1 wrote: > lgtm -- assuming rob doesn't object -- but he's ...
6 years, 8 months ago (2014-04-21 19:23:39 UTC) #3
robertphillips
lgtm
6 years, 8 months ago (2014-04-22 13:14:55 UTC) #4
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 8 months ago (2014-04-22 13:15:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/243333008/1
6 years, 8 months ago (2014-04-22 13:15:51 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 13:33:18 UTC) #7
Message was sent while issue was closed. 
Change committed as 14295

Powered by Google App Engine
This is Rietveld 408576698