Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2433323004: Automatically CC folks listed in CC= lines. (Closed)

Created:
4 years, 2 months ago by bradnelson
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Automatically CC folks listed in CC= lines. Detect CC=<users> lines the way we detect R= and TBR=. Add these as CC'ed users for rietveld and gerrit. R=iannucci@chromium.org,hinoka@chromium.org,dnj@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d975b30c20b53879bf466d9c82a59813ea8122e6

Patch Set 1 #

Patch Set 2 : added tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M git_cl.py View 4 chunks +11 lines, -0 lines 0 comments Download
M tests/git_cl_test.py View 1 11 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
bradn
4 years, 2 months ago (2016-10-20 20:32:50 UTC) #2
iannucci
lgtm
4 years, 2 months ago (2016-10-20 20:38:23 UTC) #3
tandrii(chromium)
Very nice. Can you also modify this tests by adding CC= line to description, perhaps ...
4 years, 2 months ago (2016-10-20 20:53:52 UTC) #5
bradnelson
PTAL
4 years, 2 months ago (2016-10-22 19:43:33 UTC) #8
tandrii(chromium)
LGTM, thank you!
4 years, 2 months ago (2016-10-23 13:52:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433323004/20001
4 years, 2 months ago (2016-10-23 19:17:08 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-23 19:20:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d975b30c20b538...

Powered by Google App Engine
This is Rietveld 408576698