[Media Router] Use origin instead of URL for frame.

[Media Router] Use origin instead of URL for frame.

This CL uses the last committed origin of a frame making a presentation request,
instead of the full URL.  Frames created in script have an empty last committed URL.

Note the following:

- Only the origin is used from the frame URL presentation request (that is why
  this change is safe).  PresentationRequest should be converted to use
  url::Origin instead of GURL to avoid unnecessary conversions.  Tracked in
  crbug.com/632623.

- Is it possible for a frames to not have a last committed origin?  If so, the
  strict checking for valid, non-empty origins will need to be relaxed.

- TODO: Add functional tests in a separate patch.

BUG=658409
Committed: https://crrev.com/e0c208309294e9c5132e713e8b04872b90c184a5
Cr-Commit-Position: refs/heads/master@{#427128}

[mark a. foltz, 2016-10-21 21:49:22]

mfoltz@chromium.org changed reviewers:
+ imcheng@chromium.org

[imcheng, 2016-10-21 23:58:03]

lgtm

https://codereview.chromium.org/2433283005/diff/1/chrome/browser/ui/webui/med...
File chrome/browser/ui/webui/media_router/media_router_ui.cc (right):

https://codereview.chromium.org/2433283005/diff/1/chrome/browser/ui/webui/med...
chrome/browser/ui/webui/media_router/media_router_ui.cc:425:
DCHECK(origin->is_valid());
We should probably remove this DCHECK since we are already validating it during
CreateRoute/ConnectRoutebyRouteId.

[mark a. foltz, 2016-10-24 17:16:42]

On 2016/10/21 at 23:58:03, imcheng wrote:
> lgtm
> 
>
https://codereview.chromium.org/2433283005/diff/1/chrome/browser/ui/webui/med...
> File chrome/browser/ui/webui/media_router/media_router_ui.cc (right):
> 
>
https://codereview.chromium.org/2433283005/diff/1/chrome/browser/ui/webui/med...
> chrome/browser/ui/webui/media_router/media_router_ui.cc:425:
DCHECK(origin->is_valid());
> We should probably remove this DCHECK since we are already validating it
during CreateRoute/ConnectRoutebyRouteId.

Done.

[mark a. foltz, 2016-10-24 17:17:03]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2016-10-24 17:17:03]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2433283005/#ps20001
(title: "Remove DCHECK in media_router_ui.cc")

[commit-bot: I haz the power, 2016-10-24 17:17:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 20:00:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-24 20:03:13]

Description was changed from

==========
[Media Router] Use origin instead of URL for frame.

This CL uses the last committed origin of a frame making a presentation request,
instead of the full URL.  Frames created in script have an empty last committed
URL.

Note the following:

- Only the origin is used from the frame URL presentation request (that is why
  this change is safe).  PresentationRequest should be converted to use
  url::Origin instead of GURL to avoid unnecessary conversions.  Tracked in
  crbug.com/632623.

- Is it possible for a frames to not have a last committed origin?  If so, the
  strict checking for valid, non-empty origins will need to be relaxed.

- TODO: Add functional tests in a separate patch.

BUG=658409
==========

to

==========
[Media Router] Use origin instead of URL for frame.

This CL uses the last committed origin of a frame making a presentation request,
instead of the full URL.  Frames created in script have an empty last committed
URL.

Note the following:

- Only the origin is used from the frame URL presentation request (that is why
  this change is safe).  PresentationRequest should be converted to use
  url::Origin instead of GURL to avoid unnecessary conversions.  Tracked in
  crbug.com/632623.

- Is it possible for a frames to not have a last committed origin?  If so, the
  strict checking for valid, non-empty origins will need to be relaxed.

- TODO: Add functional tests in a separate patch.

BUG=658409

Committed: https://crrev.com/e0c208309294e9c5132e713e8b04872b90c184a5
Cr-Commit-Position: refs/heads/master@{#427128}
==========

[commit-bot: I haz the power, 2016-10-24 20:03:13]

Patchset 2 (id:??) landed as
https://crrev.com/e0c208309294e9c5132e713e8b04872b90c184a5
Cr-Commit-Position: refs/heads/master@{#427128}