Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.cc

Issue 2433273003: service worker: Plumb NavigationPreloadManager.enable/disable to browser-side (Closed)
Patch Set: comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/web_service_worker_registration_impl.cc
diff --git a/content/child/service_worker/web_service_worker_registration_impl.cc b/content/child/service_worker/web_service_worker_registration_impl.cc
index f9e18f99aa9d2b0d43a143158766c38b72aebfe0..8a00525d973f9817282c3cb6b8010b140bdd9f04 100644
--- a/content/child/service_worker/web_service_worker_registration_impl.cc
+++ b/content/child/service_worker/web_service_worker_registration_impl.cc
@@ -147,21 +147,17 @@ void WebServiceWorkerRegistrationImpl::unregister(
}
void WebServiceWorkerRegistrationImpl::enableNavigationPreload(
- WebEnableNavigationPreloadCallbacks* callbacks) {
- std::unique_ptr<WebEnableNavigationPreloadCallbacks> owned_callbacks(
- callbacks);
- // TODO(falken): Implement this.
- owned_callbacks->onError(blink::WebServiceWorkerError(
- blink::WebServiceWorkerError::ErrorTypeAbort, "Not implemented"));
-}
-
-void WebServiceWorkerRegistrationImpl::disableNavigationPreload(
- WebDisableNavigationPreloadCallbacks* callbacks) {
- std::unique_ptr<WebDisableNavigationPreloadCallbacks> owned_callbacks(
- callbacks);
- // TODO(falken): Implement this.
- owned_callbacks->onError(blink::WebServiceWorkerError(
- blink::WebServiceWorkerError::ErrorTypeAbort, "Not implemented"));
+ bool enable,
+ blink::WebServiceWorkerProvider* provider,
+ std::unique_ptr<WebEnableNavigationPreloadCallbacks> callbacks) {
+ WebServiceWorkerProviderImpl* provider_impl =
+ static_cast<WebServiceWorkerProviderImpl*>(provider);
+ ServiceWorkerDispatcher* dispatcher =
+ ServiceWorkerDispatcher::GetThreadSpecificInstance();
+ DCHECK(dispatcher);
+ dispatcher->EnableNavigationPreload(provider_impl->provider_id(),
+ registration_id(), enable,
+ std::move(callbacks));
}
int64_t WebServiceWorkerRegistrationImpl::registration_id() const {

Powered by Google App Engine
This is Rietveld 408576698