service worker: Plumb NavigationPreloadManager.enable/disable to browser-side

content/common/service_worker/service_worker_messages.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Message definition file, included multiple times, hence no include guard.
 
 #include <stdint.h>
 
 #include <string>
 #include <vector>
@@ skipping 169 matching lines @@
 IPC_MESSAGE_CONTROL3(ServiceWorkerHostMsg_GetRegistrations,
                      int /* thread_id */,
                      int /* request_id */,
                      int /* provider_id */)
 
 IPC_MESSAGE_CONTROL3(ServiceWorkerHostMsg_GetRegistrationForReady,
                      int /* thread_id */,
                      int /* request_id */,
                      int /* provider_id */)
 
+// Asks the browser to enable/disable navigation preload for a registration.
+IPC_MESSAGE_CONTROL5(ServiceWorkerHostMsg_EnableNavigationPreload,
+                     int /* thread_id */,
+                     int /* request_id */,
+                     int /* provider_id */,
+                     int64_t /* registration_id */,
+                     bool /* enable */)
+
 // Sends ExtendableMessageEvent to a service worker (renderer->browser).
 IPC_MESSAGE_CONTROL5(
     ServiceWorkerHostMsg_PostMessageToWorker,
     int /* handle_id */,
     int /* provider_id */,
     base::string16 /* message */,
     url::Origin /* source_origin */,
     std::vector<int> /* sent_message_ports */)
 
 // Informs the browser of a new ServiceWorkerProvider in the child process,
@@ skipping 268 matching lines @@
                      int /* registration_handle_id */)
 
 // Tells the child process to set the controller ServiceWorker for the given
 // provider.
 IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_SetControllerServiceWorker,
                      int /* thread_id */,
                      int /* provider_id */,
                      content::ServiceWorkerObjectInfo,
                      bool /* should_notify_controllerchange */)
 
+IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_DidEnableNavigationPreload,
+                     int /* thread_id */,
+                     int /* request_id */)
+IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_EnableNavigationPreloadError,
+                     int /* thread_id */,
+                     int /* request_id */,
+                     blink::WebServiceWorkerError::ErrorType /* code */,
+                     base::string16 /* message */)

[nasko, 2016/10/21 16:42:02]

Can we transfer the message as std::string and do the conversion in the renderer
process? It will save us memory, as most strings are going to be ASCII anyway
and converting to string16 will double the size.

[falken, 2016/10/24 05:14:42]

Yes this puzzled me recently too. For some reason all service worker messages
use string16. It might be required to support weird strings with unpaired
surrogates (see https://bugs.chromium.org/p/chromium/issues/detail?id=592011 and
https://codereview.chromium.org/1768063002/) but we shouldn't worry about
supporting those. If WebString::fromUtf8 results in a null string,
ServiceWorkerError::take will use the default message anyway without crashing.

Done for this patch, I'll update the other messages too if this makes sense.

[nasko, 2016/10/24 15:54:48]

Thanks for the background info!
 
Yes, it makes sense. The less data we shuffle through process boundaries, the
more performant we will be and less memory usage. I'll be happy to review those
patches :).

+
 // Sends MessageEvent to a client document (browser->renderer).
 IPC_MESSAGE_CONTROL1(ServiceWorkerMsg_MessageToDocument,
                      ServiceWorkerMsg_MessageToDocument_Params)
 
 // Sent via EmbeddedWorker to dispatch events.
 IPC_MESSAGE_CONTROL1(ServiceWorkerMsg_InstallEvent,
                      int /* request_id */)
 IPC_MESSAGE_CONTROL1(ServiceWorkerMsg_ActivateEvent,
                      int /* request_id */)
 IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_ExtendableMessageEvent,
@@ skipping 52 matching lines @@
 
 // Sent via EmbeddedWorker as a response of NavigateClient.
 IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_NavigateClientResponse,
                      int /* request_id */,
                      content::ServiceWorkerClientInfo /* client */)
 
 // Sent via EmbeddedWorker as an error response of NavigateClient.
 IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_NavigateClientError,
                      int /* request_id */,
                      GURL /* url */)