tests_lit/llvm2ice_tests/return_immediates.ll - Issue 2433243003: Subzero, MIPS32: Remove --skip-unimplemented from lit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests_lit/llvm2ice_tests/return_immediates.ll

Issue 2433243003: Subzero, MIPS32: Remove --skip-unimplemented from lit tests (Closed)

Patch Set: Reverted --skip-unimplemented in nacl-other-intrinsics.ll Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests_lit/llvm2ice_tests/return_immediates.ll

diff --git a/tests_lit/llvm2ice_tests/return_immediates.ll b/tests_lit/llvm2ice_tests/return_immediates.ll

index 703785943e6c07288bbf726667f744d04594198f..f5515069479cb84166389dfddbc476022ceb3b39 100644

--- a/tests_lit/llvm2ice_tests/return_immediates.ll

+++ b/tests_lit/llvm2ice_tests/return_immediates.ll

@@ -11,12 +11,10 @@

; RUN: | %if --need=target_ARM32 \

; RUN: --command FileCheck --check-prefix ARM32 %s

-; TODO(rkotler): Stop skipping unimplemented parts (via --skip-unimplemented)

-; once enough infrastructure is in. Also, switch to --filetype=obj

-; when possible.

+; TODO: Switch to --filetype=obj when possible.

; RUN: %if --need=target_MIPS32 --need=allow_dump \

; RUN: --command %p2i --filetype=asm --assemble \

-; RUN: --disassemble --target mips32 -i %s --args -O2 --skip-unimplemented \

+; RUN: --disassemble --target mips32 -i %s --args -O2 \

; RUN: | %if --need=target_MIPS32 --need=allow_dump \

; RUN: --command FileCheck --check-prefix MIPS32 %s