Subzero, MIPS32: Remove --skip-unimplemented from lit tests

tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll

 ; This tests the NaCl intrinsics not related to atomic operations.
 
 ; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --disassemble \
 ; RUN:   --target x8632 --sandbox -i %s --args -O2 \
 ; RUN:   -allow-externally-defined-symbols \
 ; RUN:   | %if --need=target_X8632 --command FileCheck %s
 ; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --disassemble \
 ; RUN:   --target x8632 --sandbox -i %s --args -Om1 \
 ; RUN:   -allow-externally-defined-symbols \
 ; RUN:   | %if --need=target_X8632 --command FileCheck %s
@@ skipping 18 matching lines @@
 
 ; RUN: %if --need=target_ARM32 \
 ; RUN:   --command %p2i --filetype=obj --disassemble --target arm32 \
 ; RUN:   -i %s --args -O2 \
 ; RUN:   -allow-externally-defined-symbols \
 ; RUN:   | %if --need=target_ARM32 \
 ; RUN:   --command FileCheck --check-prefix ARM32 %s
 
 ; RUN: %if --need=target_MIPS32 --need=allow_dump \
 ; RUN:   --command %p2i --filetype=asm --assemble --disassemble --target mips32\
-; RUN:   -i %s --args -Om1 --skip-unimplemented \
+; RUN:   -i %s --args -Om1 \

[Jim Stichnoth, 2016/10/25 14:22:19]

Unfortunately, this --skip-unimplemented may need to stay.
  make -f Makefile.standalone check-lit
fails (at least on my machine) because of the unimplemented stacksave and
stackrestore intrinsics.

These tests don't currently have any MIPS32 check lines, so it may seem odd that
they cause the test to fail.  I think there are two possibilities:

1. The unimplemented error message gets mixed in with the filetype=asm text
stream and makes the llvm-mc assembler fail.

2. Because of pnacl-sz's default -threads=2 setting, one thread could hit the
unimplemented error and cause an abort before another thread produces sufficient
output for the other tests.

Note that there are still a bunch of other instances of
UnimplementedLoweringError in the MIPS lowering that may not be tested by the
lit tests.  (and a few in the ARM lowering, which need investigation...)

I tried to draw out more failures of this type by changing the default
-threads=2 to -threads=100 (via IceClFlags.def) and didn't find any more, but
they could still be lurking...

 ; RUN:   -allow-externally-defined-symbols \
 ; RUN:   | %if --need=target_MIPS32 --need=allow_dump \
 ; RUN:   --command FileCheck --check-prefix MIPS32 %s
 
 declare i8* @llvm.nacl.read.tp()
 declare void @llvm.nacl.longjmp(i8*, i32)
 declare i32 @llvm.nacl.setjmp(i8*)
 declare float @llvm.sqrt.f32(float)
 declare double @llvm.sqrt.f64(double)
 declare float @llvm.fabs.f32(float)
@@ skipping 645 matching lines @@
 ; CHECK: lea {{.*}},[esp+0x10]
 ; CHECK: lea {{.*}},[esp+0x10]
 ; CHECK: call
 ; CHECK: mov esp,{{.*}}
 ; CHECK: mov esp,ebp
 ; ARM32-LABEL: test_stacksave_multiple
 ; ARM32: mov {{.*}}, sp
 ; ARM32: mov {{.*}}, sp
 ; ARM32: mov {{.*}}, sp
 ; ARM32: mov sp, {{.*}}