Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 2433233005: Cleanup: Remove unused arguments, member variable (Closed)

Created:
4 years, 2 months ago by oshima
Modified:
4 years, 1 month ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unused arguments, member variable Renamed method to reflect what it does, instead of how it's implemented. BUG=None Committed: https://crrev.com/30188759b05f607fd5a664bc95e78159b91340bf Cr-Commit-Position: refs/heads/master@{#427176}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Cleanup: Remove unused arguments, member variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -28 lines) Patch
M ash/common/wm/overview/scoped_transform_overview_window.h View 1 3 chunks +5 lines, -16 lines 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.h View 1 chunk +2 lines, -4 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
oshima
4 years, 2 months ago (2016-10-21 14:00:19 UTC) #2
varkha
Thanks for doing this! lgtm with a couple nits. https://codereview.chromium.org/2433233005/diff/1/ash/common/wm/overview/scoped_transform_overview_window.h File ash/common/wm/overview/scoped_transform_overview_window.h (right): https://codereview.chromium.org/2433233005/diff/1/ash/common/wm/overview/scoped_transform_overview_window.h#newcode124 ash/common/wm/overview/scoped_transform_overview_window.h:124: ...
4 years, 2 months ago (2016-10-21 14:17:15 UTC) #5
varkha
https://codereview.chromium.org/2433233005/diff/1/ash/common/wm/overview/scoped_transform_overview_window.h File ash/common/wm/overview/scoped_transform_overview_window.h (right): https://codereview.chromium.org/2433233005/diff/1/ash/common/wm/overview/scoped_transform_overview_window.h#newcode178 ash/common/wm/overview/scoped_transform_overview_window.h:178: gfx::Transform overview_transform_; nit: Did you mean to remove this?
4 years, 2 months ago (2016-10-21 14:19:55 UTC) #6
oshima
https://codereview.chromium.org/2433233005/diff/1/ash/common/wm/overview/scoped_transform_overview_window.h File ash/common/wm/overview/scoped_transform_overview_window.h (right): https://codereview.chromium.org/2433233005/diff/1/ash/common/wm/overview/scoped_transform_overview_window.h#newcode124 ash/common/wm/overview/scoped_transform_overview_window.h:124: // Hides the window header whose size is given ...
4 years, 1 month ago (2016-10-24 20:45:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433233005/20001
4 years, 1 month ago (2016-10-24 20:46:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 23:08:22 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 23:13:31 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30188759b05f607fd5a664bc95e78159b91340bf
Cr-Commit-Position: refs/heads/master@{#427176}

Powered by Google App Engine
This is Rietveld 408576698