Use BrowserAssociatedInterface for mojo-loading

Use BrowserAssociatedInterface for mojo-loading

With this CL, mojo-loading starts using an associated ptr for
URLLoaderFactory rather than usual interface ptr. This change is to
resolve the IPC ordering issue with related IPCs such as navigation
and Service Worker IPCs.

This CL doesn't make URLLoader or URLLoaderClient associated. It
will be done in a separate CL.

BUG=603396
Committed: https://crrev.com/7cec170843da455dfe406b29d9cec4e01b592f75
Cr-Commit-Position: refs/heads/master@{#428654}

[yhirano, 2016-10-21 06:23:46]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 06:23:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 07:52:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 07:52:17]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-10-26 07:37:23]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 07:37:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 07:52:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 07:52:15]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yhirano, 2016-10-26 07:54:08]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 07:54:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-10-26 08:08:09]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 08:08:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-10-26 08:21:42]

Patchset #3 (id:40001) has been deleted

[yhirano, 2016-10-26 08:21:47]

Patchset #2 (id:20001) has been deleted

[yhirano, 2016-10-26 08:21:51]

Patchset #1 (id:1) has been deleted

[yhirano, 2016-10-26 08:38:16]

Description was changed from

==========
Use BrowserAssociatedInterface for mojo-loading

BUG=603396
==========

to

==========
Use BrowserAssociatedInterface for mojo-loading

With this CL, mojo-loading starts using an associated ptr for
URLLoaderFactory rather than usual interface ptr. This change is to resolve
the IPC ordering issue with related IPCs such as navigation and
Service Worker.

This CL doesn't make URLLoader or URLLoaderClient associated. It
will be done in a separate CL.

BUG=603396
==========

[yhirano, 2016-10-26 08:38:48]

Description was changed from

==========
Use BrowserAssociatedInterface for mojo-loading

With this CL, mojo-loading starts using an associated ptr for
URLLoaderFactory rather than usual interface ptr. This change is to resolve
the IPC ordering issue with related IPCs such as navigation and
Service Worker.

This CL doesn't make URLLoader or URLLoaderClient associated. It
will be done in a separate CL.

BUG=603396
==========

to

==========
Use BrowserAssociatedInterface for mojo-loading

With this CL, mojo-loading starts using an associated ptr for
URLLoaderFactory rather than usual interface ptr. This change is to
resolve the IPC ordering issue with related IPCs such as navigation
and Service Worker IPCs.

This CL doesn't make URLLoader or URLLoaderClient associated. It
will be done in a separate CL.

BUG=603396
==========

[yhirano, 2016-10-26 08:55:15]

yhirano@chromium.org changed reviewers:
+ jam@chromium.org, reillyg@chromium.org

[commit-bot: I haz the power, 2016-10-26 09:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 09:04:03]

Dry run: This issue passed the CQ dry run.

[jam, 2016-10-26 15:49:39]

lgtm

[Reilly Grant (use Gerrit), 2016-10-27 22:36:55]

LGTM with nits

https://codereview.chromium.org/2433233004/diff/60001/content/browser/loader/...
File content/browser/loader/url_loader_factory_impl.cc (right):

https://codereview.chromium.org/2433233004/diff/60001/content/browser/loader/...
content/browser/loader/url_loader_factory_impl.cc:65: void
URLLoaderFactoryImpl::CreateLoaderAndStart(
// static

https://codereview.chromium.org/2433233004/diff/60001/content/browser/loader/...
content/browser/loader/url_loader_factory_impl.cc:79: void
URLLoaderFactoryImpl::SyncLoad(int32_t routing_id,
// static

[yhirano, 2016-10-28 02:27:22]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[yhirano, 2016-10-28 02:27:57]

https://codereview.chromium.org/2433233004/diff/60001/content/browser/loader/...
File content/browser/loader/url_loader_factory_impl.cc (right):

https://codereview.chromium.org/2433233004/diff/60001/content/browser/loader/...
content/browser/loader/url_loader_factory_impl.cc:65: void
URLLoaderFactoryImpl::CreateLoaderAndStart(
On 2016/10/27 22:36:55, Reilly Grant wrote:
> // static

Done.

https://codereview.chromium.org/2433233004/diff/60001/content/browser/loader/...
content/browser/loader/url_loader_factory_impl.cc:79: void
URLLoaderFactoryImpl::SyncLoad(int32_t routing_id,
On 2016/10/27 22:36:55, Reilly Grant wrote:
> // static

Done.

[commit-bot: I haz the power, 2016-10-28 02:28:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 03:39:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 03:39:55]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-10-31 04:21:37]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-10-31 04:21:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
reillyg@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2433233004/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-10-31 04:21:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 05:03:10]

Description was changed from

==========
Use BrowserAssociatedInterface for mojo-loading

With this CL, mojo-loading starts using an associated ptr for
URLLoaderFactory rather than usual interface ptr. This change is to
resolve the IPC ordering issue with related IPCs such as navigation
and Service Worker IPCs.

This CL doesn't make URLLoader or URLLoaderClient associated. It
will be done in a separate CL.

BUG=603396
==========

to

==========
Use BrowserAssociatedInterface for mojo-loading

With this CL, mojo-loading starts using an associated ptr for
URLLoaderFactory rather than usual interface ptr. This change is to
resolve the IPC ordering issue with related IPCs such as navigation
and Service Worker IPCs.

This CL doesn't make URLLoader or URLLoaderClient associated. It
will be done in a separate CL.

BUG=603396
==========

[commit-bot: I haz the power, 2016-10-31 05:03:11]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-10-31 05:05:05]

Description was changed from

==========
Use BrowserAssociatedInterface for mojo-loading

With this CL, mojo-loading starts using an associated ptr for
URLLoaderFactory rather than usual interface ptr. This change is to
resolve the IPC ordering issue with related IPCs such as navigation
and Service Worker IPCs.

This CL doesn't make URLLoader or URLLoaderClient associated. It
will be done in a separate CL.

BUG=603396
==========

to

==========
Use BrowserAssociatedInterface for mojo-loading

With this CL, mojo-loading starts using an associated ptr for
URLLoaderFactory rather than usual interface ptr. This change is to
resolve the IPC ordering issue with related IPCs such as navigation
and Service Worker IPCs.

This CL doesn't make URLLoader or URLLoaderClient associated. It
will be done in a separate CL.

BUG=603396

Committed: https://crrev.com/7cec170843da455dfe406b29d9cec4e01b592f75
Cr-Commit-Position: refs/heads/master@{#428654}
==========

[commit-bot: I haz the power, 2016-10-31 05:05:07]

Patchset 2 (id:??) landed as
https://crrev.com/7cec170843da455dfe406b29d9cec4e01b592f75
Cr-Commit-Position: refs/heads/master@{#428654}