Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: xfa/fwl/lightwidget/cfwl_barcode.cpp

Issue 2433133002: Remove IFWL_*::Create methods, use new (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fwl/lightwidget/cfwl_barcode.cpp
diff --git a/xfa/fwl/lightwidget/cfwl_barcode.cpp b/xfa/fwl/lightwidget/cfwl_barcode.cpp
index dd8d9f073a48a19a8a4a779473bf8fbe40f1e707..c2e8b041b123084d70132afeb8054cbb5ca4652a 100644
--- a/xfa/fwl/lightwidget/cfwl_barcode.cpp
+++ b/xfa/fwl/lightwidget/cfwl_barcode.cpp
@@ -8,6 +8,8 @@
#include <memory>
+#include "third_party/base/ptr_util.h"
+
IFWL_Barcode* CFWL_Barcode::GetWidget() {
return static_cast<IFWL_Barcode*>(m_pIface.get());
}
@@ -22,8 +24,8 @@ FWL_Error CFWL_Barcode::Initialize(const CFWL_WidgetProperties* pProperties) {
if (pProperties) {
*m_pProperties = *pProperties;
}
- std::unique_ptr<IFWL_Barcode> pBarcode(IFWL_Barcode::Create(
- m_pProperties->MakeWidgetImpProperties(&m_barcodeData)));
+ std::unique_ptr<IFWL_Barcode> pBarcode = pdfium::MakeUnique<IFWL_Barcode>(
+ m_pProperties->MakeWidgetImpProperties(&m_barcodeData));
Wei Li 2016/10/19 17:13:07 Nit, is this a bit simpler? std::unique_ptr<IFWL_B
dsinclair 2016/10/19 17:21:28 Done.
FWL_Error ret = pBarcode->Initialize();
if (ret != FWL_Error::Succeeded) {
return ret;

Powered by Google App Engine
This is Rietveld 408576698