Remove IFWL_*::Create methods, use new

xfa/fwl/core/ifwl_datetimepicker.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/ifwl_datetimepicker.h"
 
+#include "third_party/base/ptr_util.h"
 #include "xfa/fwl/core/cfwl_message.h"
 #include "xfa/fwl/core/cfwl_themebackground.h"
 #include "xfa/fwl/core/cfwl_widgetmgr.h"
 #include "xfa/fwl/core/fwl_noteimp.h"
 #include "xfa/fwl/core/ifwl_datetimecalendar.h"
 #include "xfa/fwl/core/ifwl_datetimeedit.h"
 #include "xfa/fwl/core/ifwl_formproxy.h"
 #include "xfa/fwl/core/ifwl_spinbutton.h"
 #include "xfa/fwl/core/ifwl_themeprovider.h"
 
 namespace {
 
 const int kDateTimePickerWidth = 100;
 const int kDateTimePickerHeight = 20;
 
 }  // namespace
 
-// static
-IFWL_DateTimePicker* IFWL_DateTimePicker::Create(
-    const CFWL_WidgetImpProperties& properties,
-    IFWL_Widget* pOuter) {
-  return new IFWL_DateTimePicker(properties, pOuter);
-}
-
 IFWL_DateTimePicker::IFWL_DateTimePicker(
-    const CFWL_WidgetImpProperties& properties,
-    IFWL_Widget* pOuter)
-    : IFWL_Widget(properties, pOuter),
+    const CFWL_WidgetImpProperties& properties)
+    : IFWL_Widget(properties, nullptr),
       m_iBtnState(1),
       m_iYear(-1),
       m_iMonth(-1),
       m_iDay(-1),
       m_bLBtnDown(FALSE) {
   m_rtBtn.Set(0, 0, 0, 0);
 }
 
 IFWL_DateTimePicker::~IFWL_DateTimePicker() {}
 
@@ skipping 11 matching lines @@
     return FWL_Error::Indefinite;
 
   m_pDelegate = new CFWL_DateTimePickerImpDelegate(this);
   m_pProperties->m_dwStyleExes = FWL_STYLEEXT_DTP_ShortDateFormat;
   CFWL_WidgetImpProperties propMonth;
   propMonth.m_dwStyles = FWL_WGTSTYLE_Popup | FWL_WGTSTYLE_Border;
   propMonth.m_dwStates = FWL_WGTSTATE_Invisible;
   propMonth.m_pDataProvider = &m_MonthCalendarDP;
   propMonth.m_pParent = this;
   propMonth.m_pThemeProvider = m_pProperties->m_pThemeProvider;
-  m_pMonthCal.reset(IFWL_DateTimeCalendar::Create(propMonth, this));
+
+  m_pMonthCal = pdfium::MakeUnique<IFWL_DateTimeCalendar>(propMonth, this);
   m_pMonthCal->Initialize();
   CFX_RectF rtMonthCal;
   m_pMonthCal->GetWidgetRect(rtMonthCal, TRUE);
   rtMonthCal.Set(0, 0, rtMonthCal.width, rtMonthCal.height);
   m_pMonthCal->SetWidgetRect(rtMonthCal);
   CFWL_WidgetImpProperties propEdit;
   propEdit.m_pParent = this;
   propEdit.m_pThemeProvider = m_pProperties->m_pThemeProvider;
-  m_pEdit.reset(IFWL_DateTimeEdit::Create(propEdit, this));
+
+  m_pEdit = pdfium::MakeUnique<IFWL_DateTimeEdit>(propEdit, this);
   m_pEdit->Initialize();
   RegisterEventTarget(m_pMonthCal.get());
   RegisterEventTarget(m_pEdit.get());
   return FWL_Error::Succeeded;
 }
 
 FWL_Error IFWL_DateTimePicker::Finalize() {
   if (m_pEdit) {
     m_pEdit->Finalize();
   }
@@ skipping 246 matching lines @@
 
 void IFWL_DateTimePicker::DrawDropDownButton(CFX_Graphics* pGraphics,
                                              IFWL_ThemeProvider* pTheme,
                                              const CFX_Matrix* pMatrix) {
   if ((m_pProperties->m_dwStyleExes & FWL_STYLEEXT_DTP_Spin) ==
       FWL_STYLEEXT_DTP_Spin) {
     CFWL_WidgetImpProperties prop;
     prop.m_dwStyleExes |= FWL_STYLEEXE_SPB_Vert;
     prop.m_pParent = this;
     prop.m_rtWidget = m_rtBtn;
-    IFWL_SpinButton* pSpin = IFWL_SpinButton::Create(prop, this);
+    IFWL_SpinButton* pSpin = new IFWL_SpinButton(prop);
     pSpin->Initialize();
   } else {
     CFWL_ThemeBackground param;
     param.m_pWidget = this;
     param.m_iPart = CFWL_Part::DropDownButton;
     param.m_dwStates = m_iBtnState;
     param.m_pGraphics = pGraphics;
     param.m_rtPart = m_rtBtn;
     if (pMatrix) {
       param.m_matrix.Concat(*pMatrix);
@@ skipping 113 matching lines @@
 
 void IFWL_DateTimePicker::InitProxyForm() {
   if (m_pForm)
     return;
   if (!m_pMonthCal)
     return;
   CFWL_WidgetImpProperties propForm;
   propForm.m_dwStyles = FWL_WGTSTYLE_Popup;
   propForm.m_dwStates = FWL_WGTSTATE_Invisible;
   propForm.m_pOwner = this;
-  m_pForm.reset(IFWL_FormProxy::Create(propForm, m_pMonthCal.get()));
+
+  m_pForm = pdfium::MakeUnique<IFWL_FormProxy>(propForm, m_pMonthCal.get());
   m_pForm->Initialize();
   m_pMonthCal->SetParent(m_pForm.get());
 }
 
 IFWL_DateTimeEdit* IFWL_DateTimePicker::GetDataTimeEdit() {
   return m_pEdit.get();
 }
 
 FWL_Error IFWL_DateTimePicker::DisForm_Initialize() {
   m_pProperties->m_dwStyleExes = FWL_STYLEEXT_DTP_ShortDateFormat;
   DisForm_InitDateTimeCalendar();
   DisForm_InitDateTimeEdit();
   RegisterEventTarget(m_pMonthCal.get());
   RegisterEventTarget(m_pEdit.get());
   return FWL_Error::Succeeded;
 }
 
 void IFWL_DateTimePicker::DisForm_InitDateTimeCalendar() {
   if (m_pMonthCal) {
     return;
   }
   CFWL_WidgetImpProperties propMonth;
   propMonth.m_dwStyles =
       FWL_WGTSTYLE_Popup | FWL_WGTSTYLE_Border | FWL_WGTSTYLE_EdgeSunken;
   propMonth.m_dwStates = FWL_WGTSTATE_Invisible;
   propMonth.m_pParent = this;
   propMonth.m_pDataProvider = &m_MonthCalendarDP;
   propMonth.m_pThemeProvider = m_pProperties->m_pThemeProvider;
-  m_pMonthCal.reset(IFWL_DateTimeCalendar::Create(propMonth, this));
+
+  m_pMonthCal = pdfium::MakeUnique<IFWL_DateTimeCalendar>(propMonth, this);
   m_pMonthCal->Initialize();
   CFX_RectF rtMonthCal;
   m_pMonthCal->GetWidgetRect(rtMonthCal, TRUE);
   rtMonthCal.Set(0, 0, rtMonthCal.width, rtMonthCal.height);
   m_pMonthCal->SetWidgetRect(rtMonthCal);
 }
 
 void IFWL_DateTimePicker::DisForm_InitDateTimeEdit() {
   if (m_pEdit) {
     return;
   }
   CFWL_WidgetImpProperties propEdit;
   propEdit.m_pParent = this;
   propEdit.m_pThemeProvider = m_pProperties->m_pThemeProvider;
-  m_pEdit.reset(IFWL_DateTimeEdit::Create(propEdit, this));
+
+  m_pEdit = pdfium::MakeUnique<IFWL_DateTimeEdit>(propEdit, this);
   m_pEdit->Initialize();
 }
 
 FX_BOOL IFWL_DateTimePicker::DisForm_IsMonthCalendarShowed() {
   if (!m_pMonthCal)
     return FALSE;
   return !(m_pMonthCal->GetStates() & FWL_WGTSTATE_Invisible);
 }
 
 void IFWL_DateTimePicker::DisForm_ShowMonthCalendar(FX_BOOL bActivate) {
@@ skipping 331 matching lines @@
 
 int32_t IFWL_DateTimePicker::CFWL_MonthCalendarImpDP::GetCurMonth(
     IFWL_Widget* pWidget) {
   return m_iCurMonth;
 }
 
 int32_t IFWL_DateTimePicker::CFWL_MonthCalendarImpDP::GetCurYear(
     IFWL_Widget* pWidget) {
   return m_iCurYear;
 }