Turn on eslint rule one-var and fix existing errors.

Turn on eslint rule one-var and fix existing errors.

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/09daee5a7629b57580f19eb18e98b231dae6b1e7

[alexandermont, 2016-10-20 00:11:21]

alexandermont@chromium.org changed reviewers:
+ charliea@chromium.org

[charliea (OOO until 10-5), 2016-10-20 12:26:19]

lgtm

[charliea (OOO until 10-5), 2016-10-20 12:29:55]

Please remove BUG= before submitting (the bug you pointed to isn't relevant)

[alexandermont, 2016-10-20 17:41:12]

Description was changed from

==========
Turn on eslint rule one-var and fix existing errors.

BUG=catapult:#2915
==========

to

==========
Turn on eslint rule one-var and fix existing errors.
==========

[alexandermont, 2016-10-20 17:41:13]

The CQ bit was checked by alexandermont@chromium.org

[commit-bot: I haz the power, 2016-10-20 17:41:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 18:25:41]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[alexandermont, 2016-10-20 18:27:24]

alexandermont@chromium.org changed reviewers:
+ sullivan@chromium.org

[sullivan, 2016-10-20 19:25:11]

sullivan@chromium.org changed reviewers:
+ eakuefner@chromium.org

[sullivan, 2016-10-20 19:25:11]

lgtm, but this is an interesting style rule: how did we come to deciding on it?
I looked at the documentation and it doesn't have an opinion on what style is
best: http://eslint.org/docs/rules/one-var

[alexandermont, 2016-10-20 22:18:35]

On 2016/10/20 at 19:25:11, sullivan wrote:
> lgtm, but this is an interesting style rule: how did we come to deciding on
it? I looked at the documentation and it doesn't have an opinion on what style
is best: http://eslint.org/docs/rules/one-var

I don't know, but it is in the Google style guide (section 5.1.2)

[alexandermont, 2016-10-20 22:18:44]

The CQ bit was checked by alexandermont@chromium.org

[commit-bot: I haz the power, 2016-10-20 22:18:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 22:49:49]

Description was changed from

==========
Turn on eslint rule one-var and fix existing errors.
==========

to

==========
Turn on eslint rule one-var and fix existing errors.

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-10-20 22:49:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[sullivan, 2016-10-21 13:43:31]

On 2016/10/20 22:18:35, alexandermont wrote:
> On 2016/10/20 at 19:25:11, sullivan wrote:
> > lgtm, but this is an interesting style rule: how did we come to deciding on
> it? I looked at the documentation and it doesn't have an opinion on what style
> is best: http://eslint.org/docs/rules/one-var
> 
> I don't know, but it is in the Google style guide (section 5.1.2)

Oh, great! I'm fine with it if we're just conforming to Google style.