Issue 2432993004: Properties of flattenString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2432993004: Properties of flattenString (Closed)

Created:
4 years, 2 months ago by sra1

Modified:
4 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Properties of flattenString TBR=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1e793c96b2b53fb86d63124f7cac5f842eab9043

Patch Set 1 #

Total comments: 1

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sdk/lib/_internal/js_runtime/lib/js_helper.dart	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sra1

Committed patchset #1 (id:1) manually as 1e793c96b2b53fb86d63124f7cac5f842eab9043 (presubmit successful).

4 years, 2 months ago (2016-10-19 20:53:56 UTC) #4

Siggi Cherem (dart-lang)

4 years, 2 months ago (2016-10-19 21:08:28 UTC) #5

Message was sent while issue was closed.

lgtm

https://chromiumcodereview.appspot.com/2432993004/diff/1/sdk/lib/_internal/js...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/2432993004/diff/1/sdk/lib/_internal/js...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:1039: return
JS('returns:String;depends:none;effects:none;throws:never;gvn:true',
should we have a short-hand nomenclature for none/none/never/true? e.g:
JS('String;pure')?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages