Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2432933005: Revert "Log to UMA why we would load a third-party frame" (Closed)

Created:
4 years, 2 months ago by Mathieu
Modified:
4 years, 2 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews, kinuko+watch, rwlbuis, dgrogan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Log to UMA why we would load a third-party frame" This reverts commit 89406fe9ba00bb4b543d3bb89da3d4682539a065. Causing test failures in Deferred Loading https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/96387 Original review: https://codereview.chromium.org/2389023002/ BUG=635105 TBR=isherman,dcheng NOTRY=true Committed: https://crrev.com/2723d5de8d9244cb0065a85f4fc0430a637868e8 Cr-Commit-Position: refs/heads/master@{#426462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -270 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +2 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 4 chunks +26 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +2 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp View 1 chunk +0 lines, -186 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432933005/1
4 years, 2 months ago (2016-10-20 12:53:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 13:03:14 UTC) #9
dgrogan
Did this only fail on windows?
4 years, 2 months ago (2016-10-20 16:53:51 UTC) #11
Mathieu
On 2016/10/20 16:53:51, dgrogan wrote: > Did this only fail on windows? The few bots ...
4 years, 2 months ago (2016-10-20 17:13:47 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:17:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2723d5de8d9244cb0065a85f4fc0430a637868e8
Cr-Commit-Position: refs/heads/master@{#426462}

Powered by Google App Engine
This is Rietveld 408576698