Issue 243293005: Remove several dead assignments from HarfBuzzShaper.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243293005: Remove several dead assignments from HarfBuzzShaper.cpp (Closed)

Created:
6 years, 8 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
tonyg, eae

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Remove several dead assignments from HarfBuzzShaper.cpp Remove dead assignments from HarfBuzzShaper.cpp that the clang static code analyzer was complaining about. Those variables were being assigned but never read after. R=eae@chromium.org, tonyg@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172039

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp	View	1	3 chunks	+0 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/243293005/20001

6 years, 8 months ago (2014-04-21 15:06:59 UTC) #4

Message was sent while issue was closed.

Change committed as 172039