Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 2432903002: Revert "Add DoubleTestOp instruction" (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 4124 matching lines...) Expand 10 before | Expand all | Expand 10 after
4135 switch (op_kind()) { 4135 switch (op_kind()) {
4136 case Token::kADD: __ vaddd(result, left, right); break; 4136 case Token::kADD: __ vaddd(result, left, right); break;
4137 case Token::kSUB: __ vsubd(result, left, right); break; 4137 case Token::kSUB: __ vsubd(result, left, right); break;
4138 case Token::kMUL: __ vmuld(result, left, right); break; 4138 case Token::kMUL: __ vmuld(result, left, right); break;
4139 case Token::kDIV: __ vdivd(result, left, right); break; 4139 case Token::kDIV: __ vdivd(result, left, right); break;
4140 default: UNREACHABLE(); 4140 default: UNREACHABLE();
4141 } 4141 }
4142 } 4142 }
4143 4143
4144 4144
4145 LocationSummary* DoubleTestOpInstr::MakeLocationSummary(Zone* zone,
4146 bool opt) const {
4147 const intptr_t kNumInputs = 1;
4148 const intptr_t kNumTemps = 0;
4149 LocationSummary* summary = new(zone) LocationSummary(
4150 zone, kNumInputs, kNumTemps, LocationSummary::kNoCall);
4151 summary->set_in(0, Location::RequiresFpuRegister());
4152 summary->set_out(0, Location::RequiresRegister());
4153 return summary;
4154 }
4155
4156
4157 void DoubleTestOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
4158 ASSERT(compiler->is_optimizing());
4159 const DRegister value = EvenDRegisterOf(locs()->in(0).fpu_reg());
4160 const Register result = locs()->out(0).reg();
4161 if (op_kind() == MethodRecognizer::kDouble_getIsNaN) {
4162 __ LoadObject(result, Bool::False());
4163 __ vcmpd(value, value);
4164 __ vmstat();
4165 __ LoadObject(result, Bool::True(), VS);
4166 } else {
4167 ASSERT(op_kind() == MethodRecognizer::kDouble_getIsInfinite);
4168 Label done;
4169 // TMP <- value[0:31], result <- value[32:63]
4170 __ vmovrrd(TMP, result, value);
4171 __ cmp(TMP, Operand(0));
4172 __ LoadObject(result, Bool::False(), NE);
4173 __ b(&done, NE);
4174
4175 // Mask off the sign bit.
4176 __ AndImmediate(result, result, 0x7FFFFFFF);
4177 // Compare with +infinity.
4178 __ CompareImmediate(result, 0x7FF00000);
4179 __ LoadObject(result, Bool::False(), NE);
4180 __ b(&done, NE);
4181
4182 __ LoadObject(result, Bool::True());
4183 __ Bind(&done);
4184 }
4185 }
4186
4187
4188 LocationSummary* BinaryFloat32x4OpInstr::MakeLocationSummary(Zone* zone, 4145 LocationSummary* BinaryFloat32x4OpInstr::MakeLocationSummary(Zone* zone,
4189 bool opt) const { 4146 bool opt) const {
4190 const intptr_t kNumInputs = 2; 4147 const intptr_t kNumInputs = 2;
4191 const intptr_t kNumTemps = 0; 4148 const intptr_t kNumTemps = 0;
4192 LocationSummary* summary = new(zone) LocationSummary( 4149 LocationSummary* summary = new(zone) LocationSummary(
4193 zone, kNumInputs, kNumTemps, LocationSummary::kNoCall); 4150 zone, kNumInputs, kNumTemps, LocationSummary::kNoCall);
4194 summary->set_in(0, Location::RequiresFpuRegister()); 4151 summary->set_in(0, Location::RequiresFpuRegister());
4195 summary->set_in(1, Location::RequiresFpuRegister()); 4152 summary->set_in(1, Location::RequiresFpuRegister());
4196 summary->set_out(0, Location::RequiresFpuRegister()); 4153 summary->set_out(0, Location::RequiresFpuRegister());
4197 return summary; 4154 return summary;
(...skipping 2858 matching lines...) Expand 10 before | Expand all | Expand 10 after
7056 1, 7013 1,
7057 locs()); 7014 locs());
7058 __ Drop(1); 7015 __ Drop(1);
7059 __ Pop(result); 7016 __ Pop(result);
7060 } 7017 }
7061 7018
7062 7019
7063 } // namespace dart 7020 } // namespace dart
7064 7021
7065 #endif // defined TARGET_ARCH_ARM 7022 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698