Fix ReadableStream getReader({mode: 'byob'})

third_party/WebKit/Source/core/streams/ReadableStream.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, binding, v8) {
   'use strict';
 
   const readableStreamReader = v8.createPrivateSymbol('[[reader]]');
   const readableStreamStoredError = v8.createPrivateSymbol('[[storedError]]');
   const readableStreamController = v8.createPrivateSymbol('[[controller]]');
@@ skipping 154 matching lines @@
 
       return ReadableStreamCancel(this, reason);
     }
 
     getReader({ mode } = {}) {
       if (IsReadableStream(this) === false) {
         throw new TypeError(errIllegalInvocation);
       }
 
       if (mode === 'byob') {
-        if (IsReadableByteStreamDefaultController(this[readableStreamController]) === false) {
+        // TODO(ricea): This should be "If
+        // ! IsReadableByteStreamController(this.[[readableStreamController]])
+        // is false".
+        if (IsReadableStreamDefaultController(this[readableStreamController])) {

[tyoshino (SeeGerritForStatus), 2016/10/20 10:26:01]

i think it's ok not to have this if and just throw now.

[Adam Rice, 2016/10/20 10:35:34]

Done.

           throw new TypeError(errGetReaderNotByteStream);
         }
 
-        return AcquireReadableStreamBYOBReader(this);
+        // TODO(ricea): "Return ? AcquireReadableStreamBYOBReader(this)."
       }
 
       if (mode === undefined) {
         return AcquireReadableStreamDefaultReader(this);
       }
 
       throw new RangeError(errGetReaderBadMode);
     }
 
     tee() {
@@ skipping 730 matching lines @@
   binding.ReadableStreamDefaultControllerGetDesiredSize = ReadableStreamDefaultControllerGetDesiredSize;
   binding.ReadableStreamDefaultControllerEnqueue = ReadableStreamDefaultControllerEnqueue;
   binding.ReadableStreamDefaultControllerError = ReadableStreamDefaultControllerError;
 
   binding.createReadableStreamWithExternalController =
       (underlyingSource, strategy) => {
         return new ReadableStream(
             underlyingSource, strategy, createWithExternalControllerSentinel);
       };
 });