Don't show keyboard when editing a server card.

Don't show keyboard when editing a server card.

BUG=657621
Committed: https://crrev.com/9b43e1882e4d1f32a06601f80f348d0e4526af7b
Cr-Commit-Position: refs/heads/master@{#426561}

[please use gerrit instead, 2016-10-19 21:21:59]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 21:22:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-10-19 21:23:04]

rouslan@chromium.org changed reviewers:
+ gogerald@chromium.org

[please use gerrit instead, 2016-10-19 21:23:04]

gogerald, ptal. Videos in http://crbug.com/6576211#c1. I was able to simplify
the code a bit using UiUtils.

[please use gerrit instead, 2016-10-19 21:24:21]

http://crbug.com/657621#c1

[commit-bot: I haz the power, 2016-10-19 22:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:42:32]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-10-20 18:16:35]

lgtm, neat. The only minus concern is that no error is gonna display if the
first invalid field is not dropdown field when editing card.

https://codereview.chromium.org/2432833003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
(right):

https://codereview.chromium.org/2432833003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java:118:
updateDisplayedError(true);
updateDisplayedError(isValid());?

[please use gerrit instead, 2016-10-20 18:51:44]

Sending to cq.

On 2016/10/20 18:16:35, gogerald1 wrote:
> lgtm, neat. The only minus concern is that no error is gonna display if the
> first invalid field is not dropdown field when editing card.

That's the current behavior on Chrome Dev, so I'm willing to live with it.
Perhaps in follow up patches we can pass in a "editing vs. adding" flag to the
editor, so it knows when to highlight errors better.

https://codereview.chromium.org/2432833003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
(right):

https://codereview.chromium.org/2432833003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java:118:
updateDisplayedError(true);
On 2016/10/20 18:16:35, gogerald1 wrote:
> updateDisplayedError(isValid());?

Done.

[please use gerrit instead, 2016-10-20 18:51:53]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-10-20 18:51:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2432833003/#ps20001
(title: "Show dropdown error only if it's invalid")

[commit-bot: I haz the power, 2016-10-20 18:52:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 19:28:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:21:17]

Description was changed from

==========
Don't show keyboard when editing a server card.

BUG=657621
==========

to

==========
Don't show keyboard when editing a server card.

BUG=657621

Committed: https://crrev.com/9b43e1882e4d1f32a06601f80f348d0e4526af7b
Cr-Commit-Position: refs/heads/master@{#426561}
==========

[commit-bot: I haz the power, 2016-10-21 13:21:17]

Patchset 2 (id:??) landed as
https://crrev.com/9b43e1882e4d1f32a06601f80f348d0e4526af7b
Cr-Commit-Position: refs/heads/master@{#426561}