Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/modules/presentation/PresentationRequest.h

Issue 2432723003: [Presentation API] PresentationRequest should throw SecurityError for mixed contents (Closed)
Patch Set: Resolve code review comments from Mark Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PresentationRequest_h 5 #ifndef PresentationRequest_h
6 #define PresentationRequest_h 6 #define PresentationRequest_h
7 7
8 #include "bindings/core/v8/ActiveScriptWrappable.h" 8 #include "bindings/core/v8/ActiveScriptWrappable.h"
9 #include "bindings/core/v8/ScriptPromise.h" 9 #include "bindings/core/v8/ScriptPromise.h"
10 #include "core/dom/ActiveDOMObject.h" 10 #include "core/dom/ActiveDOMObject.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 47
48 DECLARE_VIRTUAL_TRACE(); 48 DECLARE_VIRTUAL_TRACE();
49 49
50 protected: 50 protected:
51 // EventTarget implementation. 51 // EventTarget implementation.
52 void addedEventListener(const AtomicString& eventType, 52 void addedEventListener(const AtomicString& eventType,
53 RegisteredEventListener&) override; 53 RegisteredEventListener&) override;
54 54
55 private: 55 private:
56 PresentationRequest(ExecutionContext*, const KURL&); 56 PresentationRequest(ExecutionContext*, const KURL&);
57 ScriptPromise rejectWithMixedContentException(ScriptState*);
58 ScriptPromise rejectWithSandBoxException(ScriptState*);
mlamouri (slow - plz ping) 2016/10/21 09:45:43 I don't think these methods need to be part of the
zhaobin 2016/10/21 18:41:01 Done.
57 59
58 KURL m_url; 60 KURL m_url;
59 }; 61 };
60 62
61 } // namespace blink 63 } // namespace blink
62 64
63 #endif // PresentationRequest_h 65 #endif // PresentationRequest_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698