Issue 2432603002: Revert "Fix library name insert and access inconsistency on windows"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2432603002: Revert "Fix library name insert and access inconsistency on windows" (Closed)

Created:
4 years, 2 months ago by nshahan

Modified:
4 years, 2 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Fix library name insert and access inconsistency on windows" This reverts commit d8505ee2644ae4411dfade6631acd2b2e8a4fd27. It was found to cause issues in the web file system when one file was found to be within a root path. R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/3f67c24cb8fb98158df27eb18ee138572eecd9ed

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View		2 chunks	+6 lines, -7 lines	0 comments	Download

Total messages: 5 (2 generated)

nshahan

4 years, 2 months ago (2016-10-18 23:25:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3f67c24cb8fb98158df27eb18ee138572eecd9ed (presubmit successful).