chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h - Issue 2432593002: [Offline Pages] Add basic evaluation tests and related changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h

Issue 2432593002: [Offline Pages] Add basic evaluation tests and related changes. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageManualEvaluationTest.java ('K') | « chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.cc ('k') | chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h

diff --git a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h

index 72d0561b441d6b15eeb5cec5583041722e70cfa2..b86dec08827634b57c91e33826a5dca374e99381 100644

--- a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h

+++ b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h

@@ -55,7 +55,7 @@ class OfflinePageEvaluationBridge : public OfflinePageModel::Observer,

const base::android::JavaParamRef<jobject>& j_result_obj,

const base::android::JavaParamRef<jobject>& j_callback_obj);

- void PushRequestProcessing(

+ bool PushRequestProcessing(

dougarnett 2016/10/19 16:46:25 doc return val - returns if processing started?

romax 2016/10/19 19:32:42 Done.

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj,

const base::android::JavaParamRef<jobject>& j_callback_obj);