Make cursor highlighting feature work across multiple displays

Make cursor highlighting feature work across multiple displays

BUG=654221
Committed: https://crrev.com/d56bc78fd0f1da9f50db4f0fcc48ec3d7c670c8b
Cr-Commit-Position: refs/heads/master@{#427127}

[dmazzoni, 2016-10-18 21:58:08]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-10-18 21:58:34]

dmazzoni@chromium.org changed reviewers:
+ oshima@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:58:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-10-18 22:19:37]

do you have accessibility unit tests with multiple display settings? If not,
it's probably good time to add it.

[commit-bot: I haz the power, 2016-10-18 22:59:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 22:59:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-10-19 06:35:02]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-10-19 06:42:31]

Added a unit test, take a look.

[commit-bot: I haz the power, 2016-10-19 09:32:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 12:30:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 12:30:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-10-19 21:13:51]

https://codereview.chromium.org/2432583002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc
(right):

https://codereview.chromium.org/2432583002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc:149:
manager->GetRootWindowForDisplayId(displays[1].id());
you can use Shell::GetAllRootWindows()

https://codereview.chromium.org/2432583002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc:151:
LOG(ERROR) << root_window1;
nit: remove debug logs.

https://codereview.chromium.org/2432583002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc:157:
ui::ET_MOUSE_MOVED, location, location, ui::EventTimeForNow(), 0, 0));
you can just create a instance on a stack.

[dmazzoni, 2016-10-19 22:36:42]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-10-19 22:36:49]

https://codereview.chromium.org/2432583002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc
(right):

https://codereview.chromium.org/2432583002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc:149:
manager->GetRootWindowForDisplayId(displays[1].id());
On 2016/10/19 21:13:51, oshima wrote:
> you can use Shell::GetAllRootWindows()

Thanks, that's simpler.

https://codereview.chromium.org/2432583002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc:151:
LOG(ERROR) << root_window1;
On 2016/10/19 21:13:51, oshima wrote:
> nit: remove debug logs.

Done.

https://codereview.chromium.org/2432583002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc:157:
ui::ET_MOUSE_MOVED, location, location, ui::EventTimeForNow(), 0, 0));
On 2016/10/19 21:13:51, oshima wrote:
> you can just create a instance on a stack.

Done.

[commit-bot: I haz the power, 2016-10-19 22:37:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 23:34:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 23:34:32]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-10-21 22:40:02]

Friendly ping

[oshima, 2016-10-24 18:49:55]

lgtm

[dmazzoni, 2016-10-24 18:55:18]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-10-24 18:55:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 19:50:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-24 19:56:06]

Description was changed from

==========
Make cursor highlighting feature work across multiple displays

BUG=654221
==========

to

==========
Make cursor highlighting feature work across multiple displays

BUG=654221

Committed: https://crrev.com/d56bc78fd0f1da9f50db4f0fcc48ec3d7c670c8b
Cr-Commit-Position: refs/heads/master@{#427127}
==========

[commit-bot: I haz the power, 2016-10-24 19:56:08]

Patchset 3 (id:??) landed as
https://crrev.com/d56bc78fd0f1da9f50db4f0fcc48ec3d7c670c8b
Cr-Commit-Position: refs/heads/master@{#427127}